You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Dan Hecht (Code Review)" <ge...@cloudera.org> on 2018/05/24 20:23:24 UTC
[Impala-ASF-CR] IMPALA-7068: fix test unsupported text compression table location
Dan Hecht has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10504
Change subject: IMPALA-7068: fix test_unsupported_text_compression table location
......................................................................
IMPALA-7068: fix test_unsupported_text_compression table location
WAREHOUSE is defined as get_fs_path('/test-warehouse') so we
shouldn't run that through get_fs_path again. Instead, I copied
the TBL_LOCATION format from line 59.
Change-Id: I73f21866d5c2bd7d3f4a5110d4d088a718b56960
---
M tests/metadata/test_partition_metadata.py
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/10504/1
--
To view, visit http://gerrit.cloudera.org:8080/10504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I73f21866d5c2bd7d3f4a5110d4d088a718b56960
Gerrit-Change-Number: 10504
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
[Impala-ASF-CR] IMPALA-7068: fix test unsupported text compression table location
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10504 )
Change subject: IMPALA-7068: fix test_unsupported_text_compression table location
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73f21866d5c2bd7d3f4a5110d4d088a718b56960
Gerrit-Change-Number: 10504
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 May 2018 00:03:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7068: fix test unsupported text compression table location
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10504 )
Change subject: IMPALA-7068: fix test_unsupported_text_compression table location
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10504/1/tests/metadata/test_partition_metadata.py
File tests/metadata/test_partition_metadata.py:
http://gerrit.cloudera.org:8080/#/c/10504/1/tests/metadata/test_partition_metadata.py@168
PS1, Line 168: TBL_LOCATION = '%s/%s.db/%s' % (WAREHOUSE, unique_database, TBL_NAME)
> Is there a way we could detect this mistake or avoid it? E.g. make get_fs_p
I was going to add an assert, but making it idempotent is even better. In any case, will do in a separate commit after builds are green again.
--
To view, visit http://gerrit.cloudera.org:8080/10504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73f21866d5c2bd7d3f4a5110d4d088a718b56960
Gerrit-Change-Number: 10504
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 24 May 2018 20:38:44 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7068: fix test unsupported text compression table location
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10504 )
Change subject: IMPALA-7068: fix test_unsupported_text_compression table location
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2553/
--
To view, visit http://gerrit.cloudera.org:8080/10504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73f21866d5c2bd7d3f4a5110d4d088a718b56960
Gerrit-Change-Number: 10504
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 24 May 2018 20:37:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7068: fix test unsupported text compression table location
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10504 )
Change subject: IMPALA-7068: fix test_unsupported_text_compression table location
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73f21866d5c2bd7d3f4a5110d4d088a718b56960
Gerrit-Change-Number: 10504
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 24 May 2018 20:30:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7068: fix test unsupported text compression table location
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10504 )
Change subject: IMPALA-7068: fix test_unsupported_text_compression table location
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10504/1/tests/metadata/test_partition_metadata.py
File tests/metadata/test_partition_metadata.py:
http://gerrit.cloudera.org:8080/#/c/10504/1/tests/metadata/test_partition_metadata.py@168
PS1, Line 168: TBL_LOCATION = '%s/%s.db/%s' % (WAREHOUSE, unique_database, TBL_NAME)
Is there a way we could detect this mistake or avoid it? E.g. make get_fs_path() idempotent? Seems like we'll keep hitting errors of this nature until we can detect it in precommit.
--
To view, visit http://gerrit.cloudera.org:8080/10504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73f21866d5c2bd7d3f4a5110d4d088a718b56960
Gerrit-Change-Number: 10504
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 24 May 2018 20:30:41 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7068: fix test unsupported text compression table location
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10504 )
Change subject: IMPALA-7068: fix test_unsupported_text_compression table location
......................................................................
IMPALA-7068: fix test_unsupported_text_compression table location
WAREHOUSE is defined as get_fs_path('/test-warehouse') so we
shouldn't run that through get_fs_path again. Instead, I copied
the TBL_LOCATION format from line 59.
Change-Id: I73f21866d5c2bd7d3f4a5110d4d088a718b56960
Reviewed-on: http://gerrit.cloudera.org:8080/10504
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/metadata/test_partition_metadata.py
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I73f21866d5c2bd7d3f4a5110d4d088a718b56960
Gerrit-Change-Number: 10504
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>