You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by GitBox <gi...@apache.org> on 2023/01/19 08:45:54 UTC

[GitHub] [streampipes] aamirxshaikh commented on a diff in pull request #1120: [#877] Format and lint core-ui module

aamirxshaikh commented on code in PR #1120:
URL: https://github.com/apache/streampipes/pull/1120#discussion_r1080957300


##########
ui/src/app/core-ui/data-download-dialog/components/select-data/select-data-range/select-data-range.component.html:
##########
@@ -19,73 +19,83 @@
 <h5>Data Range</h5>
 <mat-radio-group
     class="sp-radio-group"
-    [(ngModel)]="dataExportConfig.dataRangeConfiguration">
-  <mat-radio-button
-      value="visible"
-      class="sp-radio-button"
-      data-cy="download-configuration-visible"
-      *ngIf="dataExplorerDataConfig">
-    Currently configured query
-  </mat-radio-button>
-  <!--  <div fxLayout="column"-->
-  <!--       fxLayoutAlign="start start"-->
-  <!--       class="ml-35 mb-10"-->
-  <!--       *ngIf="dataExportConfig.dataRangeConfiguration === 'visible' && dataExplorerDataConfig && dataExplorerDataConfig.sourceConfigs.length > 1">-->
-  <!--    <h5>Select source (only one source can be exported in a single file)</h5>-->
-  <!--    <mat-radio-group-->
-  <!--        class="sp-radio-group"-->
-  <!--        fxLayout="column">-->
-  <!--      &lt;!&ndash;        [ngModel]="ngModel_1"&ndash;&gt;-->
-  <!--      &lt;!&ndash;        (ngModelChange)="ngModel_1Change.emit($event)"&ndash;&gt;-->
-  <!--      <mat-radio-button-->
-  <!--          class="p-5"-->
-  <!--          [value]="i"-->
-  <!--          *ngFor="let sourceConfig of dataExplorerDataConfig.sourceConfigs; let i = index">-->
-  <!--        {{sourceConfig.measureName}}-->
-  <!--      </mat-radio-button>-->
-  <!--    </mat-radio-group>-->
-  <!--  </div>-->
-  <mat-radio-button
-      value="all"
-      class="sp-radio-button"
-      data-cy="download-configuration-all">
-    All data in database
-  </mat-radio-button>
-  <mat-radio-button
-      value="customInterval"
-      class="sp-radio-button"
-      data-cy="download-configuration-customInterval">
-    All data in custom time interval
-  </mat-radio-button>
+    [(ngModel)]="dataExportConfig.dataRangeConfiguration"
+>
+    <mat-radio-button
+        value="visible"
+        class="sp-radio-button"
+        data-cy="download-configuration-visible"
+        *ngIf="dataExplorerDataConfig"
+    >
+        Currently configured query
+    </mat-radio-button>
+    <!--  <div fxLayout="column"-->

Review Comment:
   Sure @bossenti 👍



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org