[GitHub] [arrow-ballista] mingmwang opened a new issue, #114: Add timeout settings for Grpc Client

[GitBox <gi...@apache.org>]

mingmwang opened a new issue, #114:
URL: https://github.com/apache/arrow-ballista/issues/114

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] 
   (This section helps Arrow developers understand the context and *why* for this feature, in addition to  the *what*)
   
   The current GRpc clients: SchedulerGrpcClient, ExecutorGrpcClient and FlightServiceClient do not configure any timeout settings.
   We should have a default timeout settings for interactions between the system components.
   
   The reason that there is no timeout setting is because we use the tonic build generate client code and method to connect to the
   remote Grpc Server.
   
   ````
   impl ExecutorGrpcClient<tonic::transport::Channel> {
           /// Attempt to create a new client by connecting to a given endpoint.
           pub async fn connect<D>(dst: D) -> Result<Self, tonic::transport::Error>
           where
               D: std::convert::TryInto<tonic::transport::Endpoint>,
               D::Error: Into<StdError>,
           {
               let conn = tonic::transport::Endpoint::new(dst)?.connect().await?;
               Ok(Self::new(conn))
           }
       }
   
   ````
   We should pass in our own channel via new on the generated types that we can then set the timeout.
   
   
   
   **Describe the solution you'd like**
   A clear and concise description of what you want to happen.
   
   **Describe alternatives you've considered**
   A clear and concise description of any alternative solutions or features you've considered.
   
   **Additional context**
   Add any other context or screenshots about the feature request here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-ballista] andygrove closed issue #114: Add timeout settings for Grpc Client

[GitBox <gi...@apache.org>]

andygrove closed issue #114: Add timeout settings for Grpc Client
URL: https://github.com/apache/arrow-ballista/issues/114


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org