You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/04/18 09:58:16 UTC
[GitHub] [flink] KurtYoung commented on a change in pull request #8202:
[FLINK-12133] [table-runtime-blink] Support unbounded aggregate in
streaming table runtime
KurtYoung commented on a change in pull request #8202: [FLINK-12133] [table-runtime-blink] Support unbounded aggregate in streaming table runtime
URL: https://github.com/apache/flink/pull/8202#discussion_r276594279
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/rank/AbstractRankFunction.java
##########
@@ -94,10 +94,18 @@
protected long hitCount = 0L;
protected long requestCount = 0L;
- AbstractRankFunction(long minRetentionTime, long maxRetentionTime, BaseRowTypeInfo inputRowType,
- GeneratedRecordComparator generatedSortKeyComparator, BaseRowKeySelector sortKeySelector,
- RankType rankType, RankRange rankRange, GeneratedRecordEqualiser generatedEqualiser,
- boolean generateRetraction, boolean outputRankNumber) {
+ AbstractRankFunction(
+ long minRetentionTime,
Review comment:
Actually these need to indent with 2 tabs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services