You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by nd...@apache.org on 2022/01/24 22:21:39 UTC
[hbase] branch branch-2.5 updated: HBASE-26474 Implement connection-level attributes (addendum)
This is an automated email from the ASF dual-hosted git repository.
ndimiduk pushed a commit to branch branch-2.5
in repository https://gitbox.apache.org/repos/asf/hbase.git
The following commit(s) were added to refs/heads/branch-2.5 by this push:
new 4aa31ce HBASE-26474 Implement connection-level attributes (addendum)
4aa31ce is described below
commit 4aa31ce0cd3ccc7c6852883d6fcd29901d9dc69f
Author: Nick Dimiduk <nd...@apache.org>
AuthorDate: Wed Jan 12 13:34:51 2022 -0800
HBASE-26474 Implement connection-level attributes (addendum)
Addressing additional comments raised in branch-2 backport PR #4014
---
.../hadoop/hbase/client/AbstractRpcBasedConnectionRegistry.java | 5 -----
.../apache/hadoop/hbase/client/TestRpcBasedRegistryHedgedReads.java | 4 ++++
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AbstractRpcBasedConnectionRegistry.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AbstractRpcBasedConnectionRegistry.java
index 0ee374d..54138d3 100644
--- a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AbstractRpcBasedConnectionRegistry.java
+++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AbstractRpcBasedConnectionRegistry.java
@@ -273,11 +273,6 @@ abstract class AbstractRpcBasedConnectionRegistry implements ConnectionRegistry
}
@Override
- public String getConnectionString() {
- return "unimplemented";
- }
-
- @Override
public void close() {
trace(() -> {
if (registryEndpointRefresher != null) {
diff --git a/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestRpcBasedRegistryHedgedReads.java b/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestRpcBasedRegistryHedgedReads.java
index 29a9c7f..e534ab0 100644
--- a/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestRpcBasedRegistryHedgedReads.java
+++ b/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestRpcBasedRegistryHedgedReads.java
@@ -167,6 +167,10 @@ public class TestRpcBasedRegistryHedgedReads {
protected CompletableFuture<Set<ServerName>> fetchEndpoints() {
return CompletableFuture.completedFuture(BOOTSTRAP_NODES);
}
+
+ @Override public String getConnectionString() {
+ return "unimplemented";
+ }
};
}