You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-dev@jackrabbit.apache.org by "angela (JIRA)" <ji...@apache.org> on 2012/07/19 17:27:33 UTC

[jira] [Resolved] (OAK-198) Refactor RootImpl#merge

     [ https://issues.apache.org/jira/browse/OAK-198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

angela resolved OAK-198.
------------------------

       Resolution: Fixed
    Fix Version/s: 0.4

Committed revision 1363383
                
> Refactor RootImpl#merge
> -----------------------
>
>                 Key: OAK-198
>                 URL: https://issues.apache.org/jira/browse/OAK-198
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>            Reporter: angela
>             Fix For: 0.4
>
>
> IMO the anonymous inner NodeStateDiff implementation created in
> RootImpl#merge method makes the Root implementation quite cumbersome
> to read (the static method has > 150 lines of code while the actual RootImpl
> class just has around 200 lines).
> i would therefore suggest to refactor the code and move the NodeStateDiff
> implementation and the merge method in a separate class.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira