You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "AlenkaF (via GitHub)" <gi...@apache.org> on 2023/03/30 15:15:03 UTC

[GitHub] [arrow] AlenkaF commented on a diff in pull request #8510: GH-15483: [C++] Add a Fixed Shape Tensor canonical ExtensionType

AlenkaF commented on code in PR #8510:
URL: https://github.com/apache/arrow/pull/8510#discussion_r1153419089


##########
cpp/src/arrow/CMakeLists.txt:
##########
@@ -805,6 +806,10 @@ if(ARROW_IPC)
   add_arrow_test(extension_type_test)
 endif()
 
+if(ARROW_JSON)
+  add_arrow_test(canonical_extension_test SOURCES extension/fixed_shape_tensor_test.cc)

Review Comment:
   I think it shouldn't be (that one was added for the install of headers, this one is for adding the tests, if I am not mistaken)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org