You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "bneradt (via GitHub)" <gi...@apache.org> on 2026/07/23 16:57:25 UTC
[PR] Fix Fedora OTEL and WAMR builds [trafficserver]
bneradt opened a new pull request, #13423:
URL: https://github.com/apache/trafficserver/pull/13423
Fedora CI could silently omit the OTEL and WAMR plugins, while
BoringSSL builds mixed system OpenSSL headers and libraries. This made
the updated dependency image appear usable without proving either
plugin could load.
This makes the Fedora presets require both plugins and selects the
matching curl and TLS roots for system OpenSSL and BoringSSL builds.
This also distinguishes BoringSSL from OpenSSL 3 during configuration
and gives the WASM targets explicit OpenSSL dependencies so both TLS
variants build and load consistently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Fedora OTEL and WAMR builds [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #13423:
URL: https://github.com/apache/trafficserver/pull/13423#issuecomment-5062546944
[approve ci rocky]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Fedora OTEL and WAMR builds [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt merged PR #13423:
URL: https://github.com/apache/trafficserver/pull/13423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Fedora OTEL and WAMR builds [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #13423:
URL: https://github.com/apache/trafficserver/pull/13423#issuecomment-5061736117
`test_cache_CacheAggregateWriteBuffer` failed. It's a flakey failure. I wrote that test, and I have tried to reproduce locally before, but I haven't succeeded in understanding the failure path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Fedora OTEL and WAMR builds [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #13423:
URL: https://github.com/apache/trafficserver/pull/13423#issuecomment-5796321725
Cherry-picked to the 10.1.x branch as d4ccc1e15aed7e288a89484a9c87503dd1a73fa6 for the 10.1.5 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Fedora OTEL and WAMR builds [trafficserver]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13423:
URL: https://github.com/apache/trafficserver/pull/13423#discussion_r3640769925
##########
CMakePresets.json:
##########
@@ -185,10 +185,12 @@
"inherits": ["ci"],
"cacheVariables": {
"ENABLE_PROBES": "ON",
- "OPENSSL_ROOT_DIR": "/opt/openssl-quic",
+ "OPENSSL_ROOT_DIR": "/usr",
"opentelemetry_ROOT": "/opt",
- "CURL_ROOT": "/opt",
+ "CURL_ROOT": "/usr",
"wamr_ROOT": "/opt",
+ "ENABLE_OTEL_TRACER": "ON",
+ "ENABLE_WASM_WAMR": "ON",
Review Comment:
The Fedora CI presets set cache variables `ENABLE_OTEL_TRACER` and `ENABLE_WASM_WAMR`, but the build system keys off `BUILD_OTEL_TRACER` and `BUILD_WASM_WAMR` (see cmake/ExperimentalPlugins.cmake and plugins/experimental/CMakeLists.txt). As-is, these lines won't actually force the OTEL tracer or WAMR WASM plugin to be built, so CI can still silently omit them.
This issue also appears on line 217 of the same file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Fedora OTEL and WAMR builds [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on code in PR #13423:
URL: https://github.com/apache/trafficserver/pull/13423#discussion_r3641011347
##########
CMakePresets.json:
##########
@@ -185,10 +185,12 @@
"inherits": ["ci"],
"cacheVariables": {
"ENABLE_PROBES": "ON",
- "OPENSSL_ROOT_DIR": "/opt/openssl-quic",
+ "OPENSSL_ROOT_DIR": "/usr",
"opentelemetry_ROOT": "/opt",
- "CURL_ROOT": "/opt",
+ "CURL_ROOT": "/usr",
"wamr_ROOT": "/opt",
+ "ENABLE_OTEL_TRACER": "ON",
+ "ENABLE_WASM_WAMR": "ON",
Review Comment:
ENABLE_OTEL_TRACER and ENABLE_WASM_WAMR are the correct cache options. auto_option() creates ENABLE_<feature> and derives the corresponding BUILD_<feature> variable after checking its dependencies. With these options set to ON, configuration fails if a dependency is unavailable. I also verified that both Fedora presets report the derived BUILD_* variables as true and successfully build both plugin targets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Fedora OTEL and WAMR builds [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #13423:
URL: https://github.com/apache/trafficserver/pull/13423#issuecomment-5144757424
Cherry-picked to the 10.2.x branch as 1954d5ae9c35e089f55160af95ed4e7c1faf390a for the 10.2.0 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Fedora OTEL and WAMR builds [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #13423:
URL: https://github.com/apache/trafficserver/pull/13423#issuecomment-5063385058
Added the build label as the CMakeLists.txt change could potentially change the behavior of some build configurations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org