You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by "rishabhdaim (via GitHub)" <gi...@apache.org> on 2026/03/02 17:04:51 UTC

[PR] OAK-12121 : add regression tests for offline compaction not persisting gc.log [jackrabbit-oak]

rishabhdaim opened a new pull request, #2776:
URL: https://github.com/apache/jackrabbit-oak/pull/2776

   ## Summary
   
   - Adds `OfflineCompactionGcLogTest` — three regression tests that directly expose the bug where offline compaction (`compactFull()` + `cleanup()` as separate calls) never writes a gc.log entry
   - All three tests fail against the unfixed code and pass once the fix retaining `CompactionResult` across the two calls is applied
   
   ## Changes
   
   - `oak-segment-tar/src/test/java/.../file/OfflineCompactionGcLogTest.java` (new file)
     - `testOfflineCompactionPersistsGcLog` — basic offline compaction scenario: verifies gc.log has a valid entry with non-empty root id and incremented GC generation
     - `testCleanupFirstCompactOkCleanupGcLogWritten` — cleanup → compact → cleanup: pre-compaction cleanup must not write gc.log; only the post-compaction cleanup should
     - `testCompactOkCleanupCleanupGcLogHasExactlyOneEntry` — compact → cleanup → cleanup: first cleanup writes, second must not write a duplicate
   
   ## Test Plan
   
   - [ ] All three new tests fail on unfixed code (regression tests)
   - [ ] All three new tests pass once the fix is applied
   
   ## Links
   
   - JIRA: https://issues.apache.org/jira/browse/OAK-12121


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OAK-12121 : add regression tests for offline compaction not persisting gc.log [jackrabbit-oak]

Posted by "rishabhdaim (via GitHub)" <gi...@apache.org>.
rishabhdaim commented on PR #2776:
URL: https://github.com/apache/jackrabbit-oak/pull/2776#issuecomment-3985659035

   @lweitzendorf could you please review these test cases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OAK-12121 : add regression tests for offline compaction not persisting gc.log [jackrabbit-oak]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #2776:
URL: https://github.com/apache/jackrabbit-oak/pull/2776#issuecomment-3995300992

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2776) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2776&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2776&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2776&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2776&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2776&metric=new_duplicated_lines_density&view=list)  
     
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2776)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OAK-12121 : add regression tests for offline compaction not persisting gc.log [jackrabbit-oak]

Posted by "rishabhdaim (via GitHub)" <gi...@apache.org>.
rishabhdaim merged PR #2776:
URL: https://github.com/apache/jackrabbit-oak/pull/2776


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org