You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/10/25 08:49:00 UTC

[jira] [Commented] (CAMEL-11944) Ensure HBaseConfiguration ClassLoader is set correctly

    [ https://issues.apache.org/jira/browse/CAMEL-11944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218262#comment-16218262 ] 

ASF GitHub Bot commented on CAMEL-11944:
----------------------------------------

GitHub user jamesnetherton opened a pull request:

    https://github.com/apache/camel/pull/2058

    CAMEL-11944: Ensure HBaseConfiguration ClassLoader is set correctly

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jamesnetherton/camel CAMEL-11944

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/2058.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2058
    
----
commit 6dd26c2ad5f7537b6ec8f6a902b7d37eab647dde
Author: James Netherton <ja...@gmail.com>
Date:   2017-10-25T06:49:13Z

    CAMEL-11944: Ensure HBaseConfiguration ClassLoader is set correctly

----


> Ensure HBaseConfiguration ClassLoader is set correctly
> ------------------------------------------------------
>
>                 Key: CAMEL-11944
>                 URL: https://issues.apache.org/jira/browse/CAMEL-11944
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-hbase
>    Affects Versions: 2.20.0
>            Reporter: James Netherton
>            Assignee: James Netherton
>            Priority: Minor
>
> Follow up on CAMEL-11692, my fix in HBaseComponent isn't quite right because a call to HBaseConfiguration.create() automatically sets the ClassLoader on the HBaseConfiguration object. Hence the conditional logic that follows is always false.
> I think it'd be better to move [this logic|https://github.com/apache/camel/blob/master/components/camel-hbase/src/main/java/org/apache/camel/component/hbase/HBaseComponent.java#L53-L59] into the preceding if block where the HBaseConfiguration is created. If folks provide their own configuration, then it's up to them to make sure they have set the ClassLoader correctly.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)