You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "timsaucer (via GitHub)" <gi...@apache.org> on 2026/04/10 20:54:23 UTC
[PR] ci: Set linker to msvc for Windows [datafusion-python]
timsaucer opened a new pull request, #1486:
URL: https://github.com/apache/datafusion-python/pull/1486
# Which issue does this PR close?
None, but the verification script was failing on windows.
# Rationale for this change
Linker was failing on 53.0.0 even though our CI builds were fine. This appears to be due to the debug build and number of linked objects in 53.0.0. This switches to msvc linker which does not have the same issue.
# What changes are included in this PR?
Sets linker flag in verification script.
# Are there any user-facing changes?
No
# Testing
Demonstration that it now works:
https://github.com/apache/datafusion-python/actions/runs/24263082673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] ci: disable symbol export on Windows verification [datafusion-python]
Posted by "timsaucer (via GitHub)" <gi...@apache.org>.
timsaucer merged PR #1486:
URL: https://github.com/apache/datafusion-python/pull/1486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] ci: Set linker to msvc for Windows [datafusion-python]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #1486:
URL: https://github.com/apache/datafusion-python/pull/1486#issuecomment-4226952183
Is there any way to test this? The verify-release-candidate workflow doesn't seem tohave run on this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] ci: Set linker to msvc for Windows [datafusion-python]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #1486:
URL: https://github.com/apache/datafusion-python/pull/1486#discussion_r3066875693
##########
.github/workflows/verify-release-candidate.yml:
##########
@@ -73,6 +73,11 @@ jobs:
version: "27.4"
repo-token: ${{ secrets.GITHUB_TOKEN }}
+ - name: Set RUSTFLAGS for Windows GNU linker
+ if: matrix.os == 'windows'
+ shell: bash
+ run: echo "RUSTFLAGS=-C link-arg=-Wl,--exclude-libs=ALL" >> "$GITHUB_ENV"
Review Comment:
the title of this PR says it is setting the linker to msvc but this seems to actually to disable automatic symbol export
https://linux.die.net/man/1/ld
```
--exclude-libs lib,lib,...
Specifies a list of archive libraries from which symbols should not be automatically exported. The library names may be delimited by commas or colons. Specifying "--exclude-libs ALL" excludes symbols in all archive libraries from automatic export. This option is available only for the i386 PE targeted port of the linker and for ELF targeted ports. For i386 PE , symbols explicitly listed in a .def file are still exported, regardless of this option. For ELF targeted ports, symbols affected by this option will be treated as hidden.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] ci: disable symbol export on Windows verification [datafusion-python]
Posted by "timsaucer (via GitHub)" <gi...@apache.org>.
timsaucer commented on PR #1486:
URL: https://github.com/apache/datafusion-python/pull/1486#issuecomment-4229566060
> Is there any way to test this? The verify-release-candidate workflow doesn't seem tohave run on this PR
Yes, I posted a link in the description where I ran it. This is a manual workflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] ci: Set linker to msvc for Windows [datafusion-python]
Posted by "timsaucer (via GitHub)" <gi...@apache.org>.
timsaucer commented on PR #1486:
URL: https://github.com/apache/datafusion-python/pull/1486#issuecomment-4226668200
FYI @kevinjqliu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org