You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Ismael Juma <is...@juma.me.uk> on 2016/12/08 13:24:44 UTC
Improvements to Jenkins pull request builder
Hi everyone,
Given the recent availability of the superior open-source pull request
builder[1] in Apache Jenkins (previously we were only able to use the
Jenkins Enterprise GH PR plugin), I have switched our PR builds to that.
I took the chance to replace the existing build with three separate builds
(scala-2.10 and jdk7, scala 2.11 and jdk8, scala 2.12 and jdk8).
As stated in KAFKA-4511, the new approach has the following advantages:
1. It is now possible to trigger a rebuild via a comment ("retest this
please")
2. We are now testing JDK 8 as part of the PR builds
3. Builds will hopefully complete faster as they run concurrently
(previously we did Scala 2.10 followed by Scala 2.11 sequentially in the
same Jenkins job)
4. Flaky tests will be more obvious as they are unlikely to fail in all
builds (we should still be aggressive in trying to avoid flakiness)
I also updated the contribution wiki page [2].
See the following for an example of how the results are reported (I tweaked
the automated PR comment slightly so it now includes the status of the
build and the JDK and Scala version):
https://github.com/apache/kafka/pull/2231
Let me know if you have any questions, suggestions, concerns or any other
feedback.
Thanks.
Ismael
[1]
https://wiki.jenkins-ci.org/display/JENKINS/GitHub+pull+request+builder+plugin
[2]
https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes
Re: Improvements to Jenkins pull request builder
Posted by Neha Narkhede <ne...@confluent.io>.
Nice! Thanks Ismael.
On Thu, Dec 8, 2016 at 10:47 AM Damian Guy <da...@gmail.com> wrote:
> Cool - thanks Ismael!
>
> On Thu, 8 Dec 2016 at 18:22 Guozhang Wang <wa...@gmail.com> wrote:
>
> > Thanks Ismael, this is suuuuuuuuper helpful!
> >
> >
> > Guozhang
> >
> > On Thu, Dec 8, 2016 at 5:24 AM, Ismael Juma <is...@juma.me.uk> wrote:
> >
> > > Hi everyone,
> > >
> > > Given the recent availability of the superior open-source pull request
> > > builder[1] in Apache Jenkins (previously we were only able to use the
> > > Jenkins Enterprise GH PR plugin), I have switched our PR builds to
> that.
> > >
> > > I took the chance to replace the existing build with three separate
> > builds
> > > (scala-2.10 and jdk7, scala 2.11 and jdk8, scala 2.12 and jdk8).
> > >
> > > As stated in KAFKA-4511, the new approach has the following advantages:
> > >
> > > 1. It is now possible to trigger a rebuild via a comment ("retest this
> > > please")
> > > 2. We are now testing JDK 8 as part of the PR builds
> > > 3. Builds will hopefully complete faster as they run concurrently
> > > (previously we did Scala 2.10 followed by Scala 2.11 sequentially in
> the
> > > same Jenkins job)
> > > 4. Flaky tests will be more obvious as they are unlikely to fail in all
> > > builds (we should still be aggressive in trying to avoid flakiness)
> > >
> > > I also updated the contribution wiki page [2].
> > >
> > > See the following for an example of how the results are reported (I
> > tweaked
> > > the automated PR comment slightly so it now includes the status of the
> > > build and the JDK and Scala version):
> > >
> > > https://github.com/apache/kafka/pull/2231
> > >
> > > Let me know if you have any questions, suggestions, concerns or any
> other
> > > feedback.
> > >
> > > Thanks.
> > > Ismael
> > >
> > > [1]
> > > https://wiki.jenkins-ci.org/display/JENKINS/GitHub+pull+
> > > request+builder+plugin
> > > [2]
> > > https://cwiki.apache.org/confluence/display/KAFKA/
> > > Contributing+Code+Changes
> > >
> >
> >
> >
> > --
> > -- Guozhang
> >
>
--
Thanks,
Neha
Re: Improvements to Jenkins pull request builder
Posted by Damian Guy <da...@gmail.com>.
Cool - thanks Ismael!
On Thu, 8 Dec 2016 at 18:22 Guozhang Wang <wa...@gmail.com> wrote:
> Thanks Ismael, this is suuuuuuuuper helpful!
>
>
> Guozhang
>
> On Thu, Dec 8, 2016 at 5:24 AM, Ismael Juma <is...@juma.me.uk> wrote:
>
> > Hi everyone,
> >
> > Given the recent availability of the superior open-source pull request
> > builder[1] in Apache Jenkins (previously we were only able to use the
> > Jenkins Enterprise GH PR plugin), I have switched our PR builds to that.
> >
> > I took the chance to replace the existing build with three separate
> builds
> > (scala-2.10 and jdk7, scala 2.11 and jdk8, scala 2.12 and jdk8).
> >
> > As stated in KAFKA-4511, the new approach has the following advantages:
> >
> > 1. It is now possible to trigger a rebuild via a comment ("retest this
> > please")
> > 2. We are now testing JDK 8 as part of the PR builds
> > 3. Builds will hopefully complete faster as they run concurrently
> > (previously we did Scala 2.10 followed by Scala 2.11 sequentially in the
> > same Jenkins job)
> > 4. Flaky tests will be more obvious as they are unlikely to fail in all
> > builds (we should still be aggressive in trying to avoid flakiness)
> >
> > I also updated the contribution wiki page [2].
> >
> > See the following for an example of how the results are reported (I
> tweaked
> > the automated PR comment slightly so it now includes the status of the
> > build and the JDK and Scala version):
> >
> > https://github.com/apache/kafka/pull/2231
> >
> > Let me know if you have any questions, suggestions, concerns or any other
> > feedback.
> >
> > Thanks.
> > Ismael
> >
> > [1]
> > https://wiki.jenkins-ci.org/display/JENKINS/GitHub+pull+
> > request+builder+plugin
> > [2]
> > https://cwiki.apache.org/confluence/display/KAFKA/
> > Contributing+Code+Changes
> >
>
>
>
> --
> -- Guozhang
>
Re: Improvements to Jenkins pull request builder
Posted by Guozhang Wang <wa...@gmail.com>.
Thanks Ismael, this is suuuuuuuuper helpful!
Guozhang
On Thu, Dec 8, 2016 at 5:24 AM, Ismael Juma <is...@juma.me.uk> wrote:
> Hi everyone,
>
> Given the recent availability of the superior open-source pull request
> builder[1] in Apache Jenkins (previously we were only able to use the
> Jenkins Enterprise GH PR plugin), I have switched our PR builds to that.
>
> I took the chance to replace the existing build with three separate builds
> (scala-2.10 and jdk7, scala 2.11 and jdk8, scala 2.12 and jdk8).
>
> As stated in KAFKA-4511, the new approach has the following advantages:
>
> 1. It is now possible to trigger a rebuild via a comment ("retest this
> please")
> 2. We are now testing JDK 8 as part of the PR builds
> 3. Builds will hopefully complete faster as they run concurrently
> (previously we did Scala 2.10 followed by Scala 2.11 sequentially in the
> same Jenkins job)
> 4. Flaky tests will be more obvious as they are unlikely to fail in all
> builds (we should still be aggressive in trying to avoid flakiness)
>
> I also updated the contribution wiki page [2].
>
> See the following for an example of how the results are reported (I tweaked
> the automated PR comment slightly so it now includes the status of the
> build and the JDK and Scala version):
>
> https://github.com/apache/kafka/pull/2231
>
> Let me know if you have any questions, suggestions, concerns or any other
> feedback.
>
> Thanks.
> Ismael
>
> [1]
> https://wiki.jenkins-ci.org/display/JENKINS/GitHub+pull+
> request+builder+plugin
> [2]
> https://cwiki.apache.org/confluence/display/KAFKA/
> Contributing+Code+Changes
>
--
-- Guozhang