You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by mureinik <gi...@git.apache.org> on 2017/03/14 10:18:19 UTC
[GitHub] commons-lang pull request #257: Apply checkstyle to test sources
GitHub user mureinik opened a pull request:
https://github.com/apache/commons-lang/pull/257
Apply checkstyle to test sources
This enforces the code style defined by the checkstyle checks to the test sources too.
This PR contains a series of patches that fix checkstyle violations, and a final patch the enables checkstyle checks on the test sources. In the cases where it would just add robustness and not improve the code's readability and maintainability (specifically - the javadoc checks), those checks are explicitly suppressed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mureinik/commons-lang test-checkstyle
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/257.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #257
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #257: Apply checkstyle to test sources
Posted by kinow <gi...@git.apache.org>.
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/257
Checked pull request locally, build passes OK. The master branch checkstyle report has 0 errors, in 154 files. This PR branch checkstyle report has 0 errors, in 331 files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request #257: Apply checkstyle to test sources
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/257
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #257: Apply checkstyle to test sources
Posted by mureinik <gi...@git.apache.org>.
Github user mureinik commented on the issue:
https://github.com/apache/commons-lang/pull/257
Updated `checkstyle-suppressions.xml` with the missing license that caused rat to fail in the CI.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #257: Apply checkstyle to test sources
Posted by kinow <gi...@git.apache.org>.
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/257
Not sure about applying that to test sources. It's normal to apply it to sources, but I must confess I'm less strict about issues in the tests. Normally quite happy about having the tests. As long as the tests are clear and easy to understand, I'm happy to manually fix a few tabs, add some extra classes or annotations, instead of block a commit to ask a contributor to fix the tests.
+0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #257: Apply checkstyle to test sources
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/257
Required changes seem reasonable. I think we should give this a try.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #257: Apply checkstyle to test sources
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/257
[](https://coveralls.io/builds/10583740)
Coverage increased (+0.04%) to 94.565% when pulling **7374d709125edc736b6fea6ada59789b808399df on mureinik:test-checkstyle** into **39a2a6fa38c5e4d1293e00f98a89698a962d6775 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---