Re: [PR] KPO write_logs does not need to use complicated pod logs reader [airflow]

["eladkal (via GitHub)" <gi...@apache.org>]

eladkal commented on code in PR #36228:
URL: https://github.com/apache/airflow/pull/36228#discussion_r1448031027


##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -703,22 +703,21 @@ def execute_complete(self, context: Context, event: dict, **kwargs):
                     remote_pod=pod,
                 )
 
-    def write_logs(self, pod: k8s.V1Pod):
+    def _write_logs(self, pod: k8s.V1Pod):

Review Comment:
   is this considered a breaking change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org