You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Shashwatpandey4 (via GitHub)" <gi...@apache.org> on 2025/05/17 21:13:31 UTC

[PR] Added test to verify decorator signature matches KubernetesPodOperator [airflow]

Shashwatpandey4 opened a new pull request, #50741:
URL: https://github.com/apache/airflow/pull/50741

   ### What this PR does
   
   Adds a test to verify that the parameters accepted by the `kubernetes_task` decorator match those of the `KubernetesPodOperator`.
   
   This addresses [issue #48448](https://github.com/apache/airflow/issues/48448), which seeks to eliminate manual tracking of changes between operators and their decorators (e.g., with comments like "also update __init__.pyi").
   
   ---
   
   ### Scope
   
   This PR:
   - Adds a dedicated test in `tests/decorators/`
   - Compares the signature of `kubernetes_task(...)` against `KubernetesPodOperator.__init__`
   - Ignores known decorator-only params (`python_callable`, `multiple_outputs`)
   - Fails if any operator param is missing from the decorator
   
   This sets the stage for adding similar tests for other decorators (e.g., Docker, virtualenv) in future PRs.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Added test to verify decorator signature matches KubernetesPodOperator [airflow]

Posted by "Shashwatpandey4 (via GitHub)" <gi...@apache.org>.
Shashwatpandey4 commented on PR #50741:
URL: https://github.com/apache/airflow/pull/50741#issuecomment-2913791030

   closing cause ignored 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Added test to verify decorator signature matches KubernetesPodOperator [airflow]

Posted by "Shashwatpandey4 (via GitHub)" <gi...@apache.org>.
Shashwatpandey4 commented on PR #50741:
URL: https://github.com/apache/airflow/pull/50741#issuecomment-2905926750

   @eladkal can you please review this, thanks !!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Added test to verify decorator signature matches KubernetesPodOperator [airflow]

Posted by "Shashwatpandey4 (via GitHub)" <gi...@apache.org>.
Shashwatpandey4 closed pull request #50741: Added test to verify decorator signature matches KubernetesPodOperator
URL: https://github.com/apache/airflow/pull/50741


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org