You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Di Li <di...@ca.ibm.com> on 2017/02/28 13:34:22 UTC
Review Request 57146: AMBARI-20221 Ambari db schema update should be
able to compare Ambari versions with build text
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57146/
-----------------------------------------------------------
Review request for Ambari and Tim Thorpe.
Bugs: AMBARI-20221
https://issues.apache.org/jira/browse/AMBARI-20221
Repository: ambari
Description
-------
SchemaUpgradeHelper should be able to handle Ambari with versions like 1.2.3_mycompany_000000 instead of just versions like 1.2.3.4
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/utils/VersionUtils.java d3d8592
ambari-server/src/test/java/org/apache/ambari/server/utils/TestVersionUtils.java 821565e
Diff: https://reviews.apache.org/r/57146/diff/
Testing
-------
existing unit tests, new unit tests, trunk cluster install
Thanks,
Di Li
Re: Review Request 57146: AMBARI-20221 Ambari db schema update should
be able to compare Ambari versions with build text
Posted by Tim Thorpe <tt...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57146/#review167101
-----------------------------------------------------------
Ship it!
Ship It!
- Tim Thorpe
On Feb. 28, 2017, 1:34 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57146/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 1:34 p.m.)
>
>
> Review request for Ambari and Tim Thorpe.
>
>
> Bugs: AMBARI-20221
> https://issues.apache.org/jira/browse/AMBARI-20221
>
>
> Repository: ambari
>
>
> Description
> -------
>
> SchemaUpgradeHelper should be able to handle Ambari with versions like 1.2.3_mycompany_000000 instead of just versions like 1.2.3.4
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/utils/VersionUtils.java d3d8592
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestVersionUtils.java 821565e
>
> Diff: https://reviews.apache.org/r/57146/diff/
>
>
> Testing
> -------
>
> existing unit tests, new unit tests, trunk cluster install
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 57146: AMBARI-20221 Ambari db schema update should
be able to compare Ambari versions with build text
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57146/#review167103
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Feb. 28, 2017, 1:34 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57146/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 1:34 p.m.)
>
>
> Review request for Ambari and Tim Thorpe.
>
>
> Bugs: AMBARI-20221
> https://issues.apache.org/jira/browse/AMBARI-20221
>
>
> Repository: ambari
>
>
> Description
> -------
>
> SchemaUpgradeHelper should be able to handle Ambari with versions like 1.2.3_mycompany_000000 instead of just versions like 1.2.3.4
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/utils/VersionUtils.java d3d8592
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestVersionUtils.java 821565e
>
> Diff: https://reviews.apache.org/r/57146/diff/
>
>
> Testing
> -------
>
> existing unit tests, new unit tests, trunk cluster install
>
>
> Thanks,
>
> Di Li
>
>