You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "yurivict (via GitHub)" <gi...@apache.org> on 2024/03/23 19:26:26 UTC
[I] cmake log doesn't adequately report what options imply what other options: ARROW_FLIGHT appears to imply ARROW_COMPUTE, but cmake doesn't say this [arrow]
yurivict opened a new issue, #40766:
URL: https://github.com/apache/arrow/issues/40766
### Describe the enhancement requested
I am building Arrow with ```-DARROW_COMPUTE:BOOL=false``` and ```-DARROW_FLIGHT:BOOL=true```.
cmake prints:
```
-- ARROW_COMPUTE=false [default=OFF]
-- Build all Arrow Compute kernels
```
and
```
-- ARROW_FLIGHT=true [default=OFF]
-- Build the Arrow Flight RPC System (requires GRPC, Protocol Buffers)
```
However, after build and install are done all headers or ARROW_COMPUTE option are installed in ```include/arrow/compute/*```. libdata/pkgconfig/arrow-compute.pc, also specific for ARROW_COMPUTE, aren't installed.
Problems:
1) cmake should either not allow the combination ```-DARROW_COMPUTE:BOOL=false -DARROW_FLIGHT:BOOL=true```, or should warn that ARROW_COMPUTE is changed to "ON".
2) It appears that the build with the above flags turns ARROW_COMPUTE to ON, but libdata/pkgconfig/arrow-compute.pc doesn't get installed.
Version: 15.0.2
FreeBSD 14.0
### Component(s)
C++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] CMake log doesn't adequately report what options imply what other options: ARROW_FLIGHT appears to imply ARROW_COMPUTE, but cmake doesn't say this [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic closed issue #40766: [C++] CMake log doesn't adequately report what options imply what other options: ARROW_FLIGHT appears to imply ARROW_COMPUTE, but cmake doesn't say this
URL: https://github.com/apache/arrow/issues/40766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] CMake log doesn't adequately report what options imply what other options: ARROW_FLIGHT appears to imply ARROW_COMPUTE, but cmake doesn't say this [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #40766:
URL: https://github.com/apache/arrow/issues/40766#issuecomment-2017029963
Does this work?
```diff
diff --git a/cpp/src/arrow/CMakeLists.txt b/cpp/src/arrow/CMakeLists.txt
index 3d1b621db0..90c45b2d40 100644
--- a/cpp/src/arrow/CMakeLists.txt
+++ b/cpp/src/arrow/CMakeLists.txt
@@ -1185,7 +1185,9 @@ add_subdirectory(testing)
add_subdirectory(array)
add_subdirectory(c)
-add_subdirectory(compute)
+if(ARROW_COMPUTE)
+ add_subdirectory(compute)
+endif()
add_subdirectory(io)
add_subdirectory(tensor)
add_subdirectory(util)
diff --git a/cpp/src/arrow/compute/CMakeLists.txt b/cpp/src/arrow/compute/CMakeLists.txt
index badcf4f2f2..11d6479451 100644
--- a/cpp/src/arrow/compute/CMakeLists.txt
+++ b/cpp/src/arrow/compute/CMakeLists.txt
@@ -19,10 +19,8 @@ add_custom_target(arrow-compute-tests)
arrow_install_all_headers("arrow/compute")
-if(ARROW_COMPUTE)
- # pkg-config support
- arrow_add_pkg_config("arrow-compute")
-endif()
+# pkg-config support
+arrow_add_pkg_config("arrow-compute")
#
# Unit tests
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] CMake log doesn't adequately report what options imply what other options: ARROW_FLIGHT appears to imply ARROW_COMPUTE, but cmake doesn't say this [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #40766:
URL: https://github.com/apache/arrow/issues/40766#issuecomment-3547075773
This issue has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this issue will be closed in 14 days. If this improvement is still desired but has no current owner, please add the 'Status: needs champion' label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] CMake log doesn't adequately report what options imply what other options: ARROW_FLIGHT appears to imply ARROW_COMPUTE, but cmake doesn't say this [arrow]
Posted by "yurivict (via GitHub)" <gi...@apache.org>.
yurivict commented on issue #40766:
URL: https://github.com/apache/arrow/issues/40766#issuecomment-3547918246
not stale
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] CMake log doesn't adequately report what options imply what other options: ARROW_FLIGHT appears to imply ARROW_COMPUTE, but cmake doesn't say this [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on issue #40766:
URL: https://github.com/apache/arrow/issues/40766#issuecomment-3921304083
This issue has been closed because there has been no activity for the 14 days since the stale warning. Feel free to reopen if this has been closed in error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org