You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/15 15:08:21 UTC

[GitHub] gengliangwang opened a new pull request #23800: [SPARK-26673][SQL] File source V2: remove duplicated broadcast object in FileWriterFactory

gengliangwang opened a new pull request #23800: [SPARK-26673][SQL] File source V2: remove duplicated broadcast object in FileWriterFactory
URL: https://github.com/apache/spark/pull/23800
 
 
   ## What changes were proposed in this pull request?
   
   This is a followup PR to fix two issues in #23601:
   1.  the class `FileWriterFactory` contains `conf: SerializableConfiguration` as a member, which is duplicated with `WriteJobDescription. serializableHadoopConf `. By removing it we can reduce the broadcast task binary size by around 70KB
   2. The test suite `OrcV1QuerySuite`/`OrcV1QuerySuite`/`OrcV1PartitionDiscoverySuite` didn't change the configuration `SQLConf.USE_V1_SOURCE_WRITER_LIST` to `"orc`. We should set the conf.
   
   ## How was this patch tested?
   
   Unit test 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org