You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Vaibhav Gumashta <vg...@hortonworks.com> on 2015/01/06 20:28:30 UTC
Review Request 29635: HiveServer2 leaks FileSystem objects in
FileSystem.CACHE
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29635/
-----------------------------------------------------------
Review request for hive and Thejas Nair.
Bugs: HIVE-9234
https://issues.apache.org/jira/browse/HIVE-9234
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-9234
Diffs
-----
service/src/java/org/apache/hive/service/cli/session/HiveSession.java 6359a5b
service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java 50094d2
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java cabf32a
service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java 7acd113
service/src/java/org/apache/hive/service/cli/session/SessionManager.java 137359b
Diff: https://reviews.apache.org/r/29635/diff/
Testing
-------
Thanks,
Vaibhav Gumashta
Re: Review Request 29635: HiveServer2 leaks FileSystem objects in
FileSystem.CACHE
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29635/#review67252
-----------------------------------------------------------
service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java
<https://reviews.apache.org/r/29635/#comment111254>
I think this needs to get called even if super.close throws an exception.
- Thejas Nair
On Jan. 6, 2015, 7:28 p.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29635/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2015, 7:28 p.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Bugs: HIVE-9234
> https://issues.apache.org/jira/browse/HIVE-9234
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-9234
>
>
> Diffs
> -----
>
> service/src/java/org/apache/hive/service/cli/session/HiveSession.java 6359a5b
> service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java 50094d2
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java cabf32a
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java 7acd113
> service/src/java/org/apache/hive/service/cli/session/SessionManager.java 137359b
>
> Diff: https://reviews.apache.org/r/29635/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>
Re: Review Request 29635: HiveServer2 leaks FileSystem objects in
FileSystem.CACHE
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29635/#review67523
-----------------------------------------------------------
Ship it!
Ship It!
- Thejas Nair
On Jan. 9, 2015, 9:01 p.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29635/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2015, 9:01 p.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Bugs: HIVE-9234
> https://issues.apache.org/jira/browse/HIVE-9234
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-9234
>
>
> Diffs
> -----
>
> service/src/java/org/apache/hive/service/cli/session/HiveSession.java 6359a5b
> service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java 50094d2
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java cabf32a
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java 7acd113
> service/src/java/org/apache/hive/service/cli/session/SessionManager.java 137359b
>
> Diff: https://reviews.apache.org/r/29635/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>
Re: Review Request 29635: HiveServer2 leaks FileSystem objects in
FileSystem.CACHE
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29635/
-----------------------------------------------------------
(Updated Jan. 9, 2015, 9:01 p.m.)
Review request for hive and Thejas Nair.
Bugs: HIVE-9234
https://issues.apache.org/jira/browse/HIVE-9234
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-9234
Diffs (updated)
-----
service/src/java/org/apache/hive/service/cli/session/HiveSession.java 6359a5b
service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java 50094d2
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java cabf32a
service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java 7acd113
service/src/java/org/apache/hive/service/cli/session/SessionManager.java 137359b
Diff: https://reviews.apache.org/r/29635/diff/
Testing
-------
Thanks,
Vaibhav Gumashta
Re: Review Request 29635: HiveServer2 leaks FileSystem objects in
FileSystem.CACHE
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
> On Jan. 9, 2015, 5:45 p.m., Brock Noland wrote:
> > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java, line 153
> > <https://reviews.apache.org/r/29635/diff/1/?file=807913#file807913line153>
> >
> > Would you mind updating:
> >
> > "fail to load reloadable jar file path" + e;
> >
> > to
> >
> > "Failed to load reloadable jar file path: " + e;
Sure, will incorporate these changes in the new patch. Thanks for taking a look.
- Vaibhav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29635/#review67455
-----------------------------------------------------------
On Jan. 6, 2015, 7:28 p.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29635/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2015, 7:28 p.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Bugs: HIVE-9234
> https://issues.apache.org/jira/browse/HIVE-9234
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-9234
>
>
> Diffs
> -----
>
> service/src/java/org/apache/hive/service/cli/session/HiveSession.java 6359a5b
> service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java 50094d2
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java cabf32a
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java 7acd113
> service/src/java/org/apache/hive/service/cli/session/SessionManager.java 137359b
>
> Diff: https://reviews.apache.org/r/29635/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>
Re: Review Request 29635: HiveServer2 leaks FileSystem objects in
FileSystem.CACHE
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29635/#review67455
-----------------------------------------------------------
Hi,
I happened to see this randomly. Since you are cleaning up some stuff, may I request the two cleanups below? Please feel free to push them off to another jira if you've already updated the patch!
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java
<https://reviews.apache.org/r/29635/#comment111478>
Would you mind updating:
"fail to load reloadable jar file path" + e;
to
"Failed to load reloadable jar file path: " + e;
service/src/java/org/apache/hive/service/cli/session/SessionManager.java
<https://reviews.apache.org/r/29635/#comment111487>
would you mind updating
Failed to open new session", e
to
Failed to open new session:" + e, e
- Brock Noland
On Jan. 6, 2015, 7:28 p.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29635/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2015, 7:28 p.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Bugs: HIVE-9234
> https://issues.apache.org/jira/browse/HIVE-9234
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-9234
>
>
> Diffs
> -----
>
> service/src/java/org/apache/hive/service/cli/session/HiveSession.java 6359a5b
> service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java 50094d2
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java cabf32a
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java 7acd113
> service/src/java/org/apache/hive/service/cli/session/SessionManager.java 137359b
>
> Diff: https://reviews.apache.org/r/29635/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>