You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/08/11 06:32:45 UTC

[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #3000: Introduce a common set of extendable messaging tests

jamesnetherton commented on a change in pull request #3000:
URL: https://github.com/apache/camel-quarkus/pull/3000#discussion_r686537093



##########
File path: tooling/scripts/validate-github-workflows.groovy
##########
@@ -30,7 +30,7 @@ final Set<String> executedBaseNames = [] as Set
 
 // Add any ignored itest modules here. Or prefix the module name with '#' to disable it
 // hystrix - https://github.com/apache/camel-quarkus/issues/1146
-final List<String> excludedModules = ['hystrix', 'nats'] as List
+final List<String> excludedModules = ['hystrix', 'messaging', 'nats'] as List

Review comment:
       > But you maybe have some reason to keep `messaging` under `integration-tests`?
   
   Mainly to avoid having to navigate away from the main itests area if you want to add / amend tests. If it were just  few tests that we were maintainting, I'd probably have put it under test-support. Since its a catalog of tests that we'll likely add to in future, I thought i made sense to keep them in the standard location.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org