You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/08/15 13:54:43 UTC
[GitHub] [shardingsphere] terrymanu opened a new pull request #11830: Refactor GovernanceShardingSphereDataSourceFactory
terrymanu opened a new pull request #11830:
URL: https://github.com/apache/shardingsphere/pull/11830
For #11709.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] taojintianxia commented on a change in pull request #11830: Refactor GovernanceShardingSphereDataSourceFactory
Posted by GitBox <gi...@apache.org>.
taojintianxia commented on a change in pull request #11830:
URL: https://github.com/apache/shardingsphere/pull/11830#discussion_r689093980
##########
File path: examples/shardingsphere-jdbc-example/governance-example/governance-raw-jdbc-example/src/main/java/org/apache/shardingsphere/example/governance/raw/jdbc/config/cloud/CloudEncryptConfiguration.java
##########
@@ -19,21 +19,21 @@
import org.apache.shardingsphere.driver.governance.api.GovernanceShardingSphereDataSourceFactory;
import org.apache.shardingsphere.example.config.ExampleConfiguration;
-import org.apache.shardingsphere.governance.repository.api.config.GovernanceConfiguration;
+import org.apache.shardingsphere.infra.mode.config.ModeConfiguration;
import javax.sql.DataSource;
import java.sql.SQLException;
public class CloudEncryptConfiguration implements ExampleConfiguration {
Review comment:
why not @RequiredArgsConstructor ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #11830: Refactor GovernanceShardingSphereDataSourceFactory
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #11830:
URL: https://github.com/apache/shardingsphere/pull/11830#discussion_r689108670
##########
File path: examples/shardingsphere-jdbc-example/governance-example/governance-raw-jdbc-example/src/main/java/org/apache/shardingsphere/example/governance/raw/jdbc/config/cloud/CloudEncryptConfiguration.java
##########
@@ -19,21 +19,21 @@
import org.apache.shardingsphere.driver.governance.api.GovernanceShardingSphereDataSourceFactory;
import org.apache.shardingsphere.example.config.ExampleConfiguration;
-import org.apache.shardingsphere.governance.repository.api.config.GovernanceConfiguration;
+import org.apache.shardingsphere.infra.mode.config.ModeConfiguration;
import javax.sql.DataSource;
import java.sql.SQLException;
public class CloudEncryptConfiguration implements ExampleConfiguration {
Review comment:
Example do not permit using lombok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss merged pull request #11830: Refactor GovernanceShardingSphereDataSourceFactory
Posted by GitBox <gi...@apache.org>.
menghaoranss merged pull request #11830:
URL: https://github.com/apache/shardingsphere/pull/11830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org