[GitHub] [incubator-iceberg] rdblue commented on issue #705: Add session catalog for Spark 3.0

[GitBox <gi...@apache.org>]

rdblue commented on issue #705: Add session catalog for Spark 3.0
URL: https://github.com/apache/incubator-iceberg/pull/705#issuecomment-568005081
 
 
   @chenjunjiedada, Catalogs throw NotIcebergException (extends NoSuchTableException) if a table is not Iceberg, so Iceberg won't try to delete a non-Iceberg table. In the case of drop, when the table is not Iceberg or is missing, the method returns false. That's why we don't use try/catch: the exception is not thrown because throwing it would violate the method contract.
   
   @jerryshao, that's why I updated the methods. This now checks that the table is Iceberg, or relies on the method contract as I explained above for drop.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org