You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "jpountz (via GitHub)" <gi...@apache.org> on 2023/09/18 16:31:46 UTC

[GitHub] [lucene] jpountz opened a new pull request, #12568: Fix issues with BP tests and the security manager.

jpountz opened a new pull request, #12568:
URL: https://github.com/apache/lucene/pull/12568

   The default ForkJoinPool implementation uses a thread factory that removes all permissions on threads, so we need to create our own to avoid tests failing with FS-based directories.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] jpountz merged pull request #12568: Fix issues with BP tests and the security manager.

Posted by "jpountz (via GitHub)" <gi...@apache.org>.
jpountz merged PR #12568:
URL: https://github.com/apache/lucene/pull/12568


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] jpountz commented on pull request #12568: Fix issues with BP tests and the security manager.

Posted by "jpountz (via GitHub)" <gi...@apache.org>.
jpountz commented on PR #12568:
URL: https://github.com/apache/lucene/pull/12568#issuecomment-1724930942

   >  Did you test with -Dtests.directory=MMapDirectory?
   
   I did.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] uschindler commented on pull request #12568: Fix issues with BP tests and the security manager.

Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #12568:
URL: https://github.com/apache/lucene/pull/12568#issuecomment-1725333605

   MMap Jenkins tests were happy, all tests passed:
   - https://jenkins.thetaphi.de/job/Lucene-MMAPv2-Linux/
   - https://jenkins.thetaphi.de/job/Lucene-MMAPv2-Windows/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] jpountz commented on pull request #12568: Fix issues with BP tests and the security manager.

Posted by "jpountz (via GitHub)" <gi...@apache.org>.
jpountz commented on PR #12568:
URL: https://github.com/apache/lucene/pull/12568#issuecomment-1725228619

   Oops, I think I confused the "Reviewers" and "Assignees" section, I didn't mean to put it on your plate!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] uschindler commented on pull request #12568: Fix issues with BP tests and the security manager.

Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #12568:
URL: https://github.com/apache/lucene/pull/12568#issuecomment-1724994726

   Thanks @jpountz for merging. I did not notice that you assigned the issue to me so I should merge it. I was about to checkout the repo and test it intensively. But as you have ran the tests with mmapdir it should all be fine! I triggered two Jenkins jobs to validate, but we're ready for 9.8.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org