You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/03/10 11:03:12 UTC
[GitHub] [cloudstack] aleskxyz opened a new issue #3957: Root disk size
reverts to its template size after rebuild
aleskxyz opened a new issue #3957: Root disk size reverts to its template size after rebuild
URL: https://github.com/apache/cloudstack/issues/3957
<!--
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release and master branch are affected too.
Always add information AFTER of these HTML comments, but no need to delete the comments.
-->
##### ISSUE TYPE
<!-- Pick one below and delete the rest -->
* Bug Report
##### COMPONENT NAME
<!--
Categorize the issue, e.g. API, VR, VPN, UI, etc.
-->
~~~
Management Server
~~~
##### CLOUDSTACK VERSION
<!--
New line separated list of affected versions, commit ID for issues on master branch.
-->
~~~
4.13
~~~
##### CONFIGURATION
<!--
Information about the configuration if relevant, e.g. basic network, advanced networking, etc. N/A otherwise
-->
CloudStack 4.13
vSphere 6.5
##### OS / ENVIRONMENT
<!--
Information about the environment if relevant, N/A otherwise
-->
##### SUMMARY
<!-- Explain the problem/feature briefly -->
##### STEPS TO REPRODUCE
<!--
For bugs, show exactly how to reproduce the problem, using a minimal test-case. Use Screenshots if accurate.
For new features, show how the feature would be used.
-->
- resize root disk to larger size
- rebuild vm
- root disk size reverts to its original template size
- CloudStack reports root disk size has not been reverted
<!-- Paste example playbooks or commands between quotes below -->
~~~
~~~
<!-- You can also paste gist.github.com links for larger files -->
##### EXPECTED RESULTS
<!-- What did you expect to happen when running the steps above? -->
~~~
~~~
##### ACTUAL RESULTS
<!-- What actually happened? -->
CloudStack resize root disk to larger size after rebuild
<!-- Paste verbatim command output between quotes below -->
~~~
~~~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] aleskxyz commented on issue #3957: Root disk size
reverts to its template size after rebuild
Posted by GitBox <gi...@apache.org>.
aleskxyz commented on issue #3957: Root disk size reverts to its template size after rebuild
URL: https://github.com/apache/cloudstack/issues/3957#issuecomment-597077559
More investigation results:
**Scenario 1:**
1. Create a VM with root disk same as template
2. Upgrade root disk
3. Rebuild VM
Result: root disk size reverts to template size
**Scenario 2:**
1. Create a VM with increased root disk size
2. Rebuild VM
Result: root disk size is ok
**Scenario 3:**
1. Create a VM with increased root disk size
2. Upgrade root disk
3. Rebuild VM
Result: root disk size is ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3957: Root disk size
reverts to its template size after rebuild
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3957: Root disk size reverts to its template size after rebuild
URL: https://github.com/apache/cloudstack/issues/3957#issuecomment-597504556
@aleskxyz glad it works for you, but now you are tying the rootDiskSize to the template instead of the diskOffering. If this template is never used with a fixed diskOffering 👍 , is it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] aleskxyz commented on issue #3957: Root disk size
reverts to its template size after rebuild
Posted by GitBox <gi...@apache.org>.
aleskxyz commented on issue #3957: Root disk size reverts to its template size after rebuild
URL: https://github.com/apache/cloudstack/issues/3957#issuecomment-597180718
> Sounds like this can be done by :
>
> 1. Create a VM with root disk same as template
> 2. (under the hood) Call "updateVirtualMachine" by adding "rootdisksize=0" to "details" list.
> 3. Upgrade root disk
> 4. Rebuild VM
> Result: root disk size should be ok
>
> are you planning to fix this @aleskxyz ?
@DaanHoogland
I really want to contribute on CS code but unfortunately I'm not a developer :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3957: Root disk size
reverts to its template size after rebuild
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3957: Root disk size reverts to its template size after rebuild
URL: https://github.com/apache/cloudstack/issues/3957#issuecomment-597219042
ok @aleskxyz , unfortunately that means there is no guarantee it will actually be implemented. I will if i find the time but make no promises
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3957: Root disk size
reverts to its template size after rebuild
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3957: Root disk size reverts to its template size after rebuild
URL: https://github.com/apache/cloudstack/issues/3957#issuecomment-597042761
@aleskxyz what diskoffering did the VM have to begin with?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] aleskxyz commented on issue #3957: Root disk size
reverts to its template size after rebuild
Posted by GitBox <gi...@apache.org>.
aleskxyz commented on issue #3957: Root disk size reverts to its template size after rebuild
URL: https://github.com/apache/cloudstack/issues/3957#issuecomment-597381823
**Better workaround:**
Based on [this line of code](https://github.com/apache/cloudstack/blob/4.13.0.0/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java#L3841) we can abuse (?!) template details and inject "rootdisksize" in vm details:
By this workaround everything goes as expected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3957: Root disk size
reverts to its template size after rebuild
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3957: Root disk size reverts to its template size after rebuild
URL: https://github.com/apache/cloudstack/issues/3957#issuecomment-597151464
Sounds like this can be done by :
1. Create a VM with root disk same as template
2. (under the hood) Call "updateVirtualMachine" by adding "rootdisksize=0" to "details" list.
3. Upgrade root disk
4. Rebuild VM
Result: root disk size should be ok
are you planning to fix this @aleskxyz ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] aleskxyz commented on issue #3957: Root disk size
reverts to its template size after rebuild
Posted by GitBox <gi...@apache.org>.
aleskxyz commented on issue #3957: Root disk size reverts to its template size after rebuild
URL: https://github.com/apache/cloudstack/issues/3957#issuecomment-597067542
> @aleskxyz what diskoffering did the VM have to begin with?
I have create VM from a template which its root disk is created from a dynamic disk offering.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] aleskxyz commented on issue #3957: Root disk size
reverts to its template size after rebuild
Posted by GitBox <gi...@apache.org>.
aleskxyz commented on issue #3957: Root disk size reverts to its template size after rebuild
URL: https://github.com/apache/cloudstack/issues/3957#issuecomment-597128458
**Workaround:**
It seems that when you increase root disk size at deployment, CloudStack initializes "rootdisksize" as a variable in "details" list with the size of root disk.
When you request for rebuild, CloudStack looks for "rootdisksize" _regardless of its value_, and recreates root disk according to its latest size.
So this scenario is a workaround to this bug:
1. Create a VM with root disk same as template
2. Upgrade root disk
3. Call "updateVirtualMachine" by adding "rootdisksize=0" to "details" list.
4. Rebuild VM
Result: root disk size is ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services