[GitHub] [incubator-superset] dflionis commented on a change in pull request #7618: Add Filter on DatabaseView that filters DBs Based on Role Access

[GitBox <gi...@apache.org>]

dflionis commented on a change in pull request #7618: Add Filter on DatabaseView that filters DBs Based on Role Access
URL: https://github.com/apache/incubator-superset/pull/7618#discussion_r289225848
 
 

 ##########
 File path: superset/security.py
 ##########
 @@ -127,12 +127,11 @@ def all_datasource_access(self):
         return self.can_access(
             'all_datasource_access', 'all_datasource_access')
 
+    def all_database_access(self):
 
 Review comment:
   A different contributor came along and added some tests to this module, but since the tests were failing and it was after Maxime's approval, I did not attempt to port them over. Happy to try to write tests if there is demand for adding them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org