You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2015/07/04 03:14:36 UTC
[GitHub] incubator-zeppelin pull request: [WIP] ZEPPELIN-148 Notebook scope...
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/143
[WIP] ZEPPELIN-148 Notebook scope AngularObject for Angular display system
Described https://issues.apache.org/jira/browse/ZEPPELIN-148
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Leemoonsoo/incubator-zeppelin localscope
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/143.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #143
----
commit cd32642be71ceb36ae7a4ffb32dc832050580033
Author: Lee moon soo <mo...@apache.org>
Date: 2015-06-28T21:08:47Z
Introduce scope (global/local) for angular object
commit cdf2ba1a72561314c7ee02359fac829063d7d6d6
Author: Lee moon soo <mo...@apache.org>
Date: 2015-06-29T18:59:58Z
Take all objects
commit 7ab6a6b319604bb695843ffebbcb6fe26915b29b
Author: Lee moon soo <mo...@apache.org>
Date: 2015-07-01T17:38:21Z
save / load angular object
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-148 Notebook scope Angul...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/143#issuecomment-119277218
This PR introduces a two different scope for a angularObject. One localScope(notebook scope) and the other globalScope(interpreter scope).
Also includes end-to-end test that covers front-end interaction.
I think this pr will really help make this feature from experimental to beta.
Ready to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-148 Notebook scope Angul...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/143#issuecomment-120657317
merging if there're no more discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-148 Notebook scope Angul...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/143#issuecomment-118452060
Ready to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-148 Notebook scope Angul...
Posted by stumped2 <gi...@git.apache.org>.
Github user stumped2 closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/143
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-148 Notebook scope Angul...
Posted by stumped2 <gi...@git.apache.org>.
Github user stumped2 commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/143#issuecomment-120987510
Closing as per https://issues.apache.org/jira/browse/INFRA-9976
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---