You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2017/05/24 11:47:31 UTC

[GitHub] brooklyn-server pull request #696: Fix DslYamlTest

GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-server/pull/696

    Fix DslYamlTest

    Test previously failed non-deterministically in jenkins (e.g. see https://github.com/apache/brooklyn-server/pull/693#issuecomment-303414269)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-server fix-DslYamlTest

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/696.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #696
    
----
commit a4b137730c9f08a61cb82aafacaea2fd1dc3ada7
Author: Aled Sage <al...@gmail.com>
Date:   2017-05-24T11:43:35Z

    Fix DslYamlTest’s getConfigEventually 
    
    Call config().get(), and then config.getNonBlocking().
    Previously did it the other way around, so the getNonBlocking could
    return absent if the value was not yet available.

commit 3200ee8c74b45c30a087ff57b6509798e69a01d3
Author: Aled Sage <al...@gmail.com>
Date:   2017-05-24T11:45:46Z

    DslYamlTest.getConfigEventually: don’t use entity’s task
    
    As per previous TODO about PR #480, we don’t need to retrieve the config
    in the context of the given entity.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #696: Fix DslYamlTest

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/696


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #696: Fix DslYamlTest

Posted by sjcorbett <gi...@git.apache.org>.

Github user sjcorbett commented on the issue:

    https://github.com/apache/brooklyn-server/pull/696
  
    Looks good, thanks @aledsage.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---