You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/04/10 01:13:00 UTC
[kudu-CR] tools: escape brackets when generating XML
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12981
Change subject: tools: escape brackets when generating XML
......................................................................
tools: escape brackets when generating XML
When building the site, we generate the XML for tools. Usually we escape
ambiguous characters for tooling arguments; it seems that wasn't the
case for arguments that are GFlags. This meant that before, we would run
into errors like the following when generating the site (new in 1.9.0
for the --predicates argument of the new `table scan` tool):
/kudu/build/release/gen-docs/kudu.xml:49: parser error : StartTag: invalid element name
* The 'Comparison' type supports <=, <, =, >, and >=,
^
Change-Id: I16c13d86b0b452e0559e245ee33373078e5e3713
---
M src/kudu/tools/tool_action.cc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/12981/1
--
To view, visit http://gerrit.cloudera.org:8080/12981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I16c13d86b0b452e0559e245ee33373078e5e3713
Gerrit-Change-Number: 12981
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] tools: escape brackets when generating XML
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12981 )
Change subject: tools: escape brackets when generating XML
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12981/2/src/kudu/tools/tool_action.cc
File src/kudu/tools/tool_action.cc:
http://gerrit.cloudera.org:8080/#/c/12981/2/src/kudu/tools/tool_action.cc@388
PS2, Line 388: gflag_info.default_value);
Should probably escape this too, since the default value for a string can have arbitrary characters in it, including HTML.
--
To view, visit http://gerrit.cloudera.org:8080/12981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16c13d86b0b452e0559e245ee33373078e5e3713
Gerrit-Change-Number: 12981
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Apr 2019 17:01:50 +0000
Gerrit-HasComments: Yes
[kudu-CR] tools: escape brackets when generating XML
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12981 )
Change subject: tools: escape brackets when generating XML
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12981/2/src/kudu/tools/tool_action.cc
File src/kudu/tools/tool_action.cc:
http://gerrit.cloudera.org:8080/#/c/12981/2/src/kudu/tools/tool_action.cc@388
PS2, Line 388: EscapeForHtmlToString(gflag_info.default_value));
> Should probably escape this too, since the default value for a string can h
Done
--
To view, visit http://gerrit.cloudera.org:8080/12981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16c13d86b0b452e0559e245ee33373078e5e3713
Gerrit-Change-Number: 12981
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Apr 2019 18:29:40 +0000
Gerrit-HasComments: Yes
[kudu-CR] tools: escape brackets when generating XML
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12981
to look at the new patch set (#2).
Change subject: tools: escape brackets when generating XML
......................................................................
tools: escape brackets when generating XML
When building the site, we generate the XML for tools. Usually we escape
ambiguous characters for tooling arguments; it seems that wasn't the
case for arguments that are GFlags. This meant that before, we would run
into errors like the following when generating the site (new in 1.9.0
for the --predicates argument of the new `perf table_scan` tool):
/kudu/build/release/gen-docs/kudu.xml:49: parser error : StartTag: invalid element name
* The 'Comparison' type supports <=, <, =, >, and >=,
^
Change-Id: I16c13d86b0b452e0559e245ee33373078e5e3713
---
M src/kudu/tools/tool_action.cc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/12981/2
--
To view, visit http://gerrit.cloudera.org:8080/12981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I16c13d86b0b452e0559e245ee33373078e5e3713
Gerrit-Change-Number: 12981
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] tools: escape brackets when generating XML
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12981
to look at the new patch set (#3).
Change subject: tools: escape brackets when generating XML
......................................................................
tools: escape brackets when generating XML
When building the site, we generate the XML for tools. Usually we escape
ambiguous characters for tooling arguments; it seems that wasn't the
case for arguments that are GFlags. This meant that before, we would run
into errors like the following when generating the site (new in 1.9.0
for the --predicates argument of the new `table scan` tool):
/kudu/build/release/gen-docs/kudu.xml:49: parser error : StartTag: invalid element name
* The 'Comparison' type supports <=, <, =, >, and >=,
^
Change-Id: I16c13d86b0b452e0559e245ee33373078e5e3713
---
M src/kudu/tools/tool_action.cc
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/12981/3
--
To view, visit http://gerrit.cloudera.org:8080/12981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I16c13d86b0b452e0559e245ee33373078e5e3713
Gerrit-Change-Number: 12981
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] tools: escape brackets when generating XML
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12981 )
Change subject: tools: escape brackets when generating XML
......................................................................
Patch Set 3: Verified+1
Failure seems unrelated.
--
To view, visit http://gerrit.cloudera.org:8080/12981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16c13d86b0b452e0559e245ee33373078e5e3713
Gerrit-Change-Number: 12981
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Apr 2019 18:54:16 +0000
Gerrit-HasComments: No
[kudu-CR] tools: escape brackets when generating XML
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has removed a vote on this change.
Change subject: tools: escape brackets when generating XML
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/12981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I16c13d86b0b452e0559e245ee33373078e5e3713
Gerrit-Change-Number: 12981
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] tools: escape brackets when generating XML
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12981 )
Change subject: tools: escape brackets when generating XML
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16c13d86b0b452e0559e245ee33373078e5e3713
Gerrit-Change-Number: 12981
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Apr 2019 18:53:51 +0000
Gerrit-HasComments: No
[kudu-CR] tools: escape brackets when generating XML
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12981 )
Change subject: tools: escape brackets when generating XML
......................................................................
tools: escape brackets when generating XML
When building the site, we generate the XML for tools. Usually we escape
ambiguous characters for tooling arguments; it seems that wasn't the
case for arguments that are GFlags. This meant that before, we would run
into errors like the following when generating the site (new in 1.9.0
for the --predicates argument of the new `table scan` tool):
/kudu/build/release/gen-docs/kudu.xml:49: parser error : StartTag: invalid element name
* The 'Comparison' type supports <=, <, =, >, and >=,
^
Change-Id: I16c13d86b0b452e0559e245ee33373078e5e3713
Reviewed-on: http://gerrit.cloudera.org:8080/12981
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/tools/tool_action.cc
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Grant Henke: Looks good to me, approved
Andrew Wong: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I16c13d86b0b452e0559e245ee33373078e5e3713
Gerrit-Change-Number: 12981
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] tools: escape brackets when generating XML
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12981 )
Change subject: tools: escape brackets when generating XML
......................................................................
Patch Set 2:
This should be backported to 1.9.x as well.
--
To view, visit http://gerrit.cloudera.org:8080/12981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16c13d86b0b452e0559e245ee33373078e5e3713
Gerrit-Change-Number: 12981
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Apr 2019 06:37:59 +0000
Gerrit-HasComments: No
[kudu-CR] tools: escape brackets when generating XML
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12981 )
Change subject: tools: escape brackets when generating XML
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16c13d86b0b452e0559e245ee33373078e5e3713
Gerrit-Change-Number: 12981
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Apr 2019 18:31:30 +0000
Gerrit-HasComments: No