You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by vieiro <gi...@git.apache.org> on 2017/10/10 05:55:36 UTC
[GitHub] incubator-netbeans pull request #113: [NETBEANS-54] Module Review libs.xerce...
GitHub user vieiro opened a pull request:
https://github.com/apache/incubator-netbeans/pull/113
[NETBEANS-54] Module Review libs.xerces
- Updated maven coordinates for Xerces 2.8.0 (Apache 2).
- Added xerces notice from https://svn.apache.org/repos/asf/xerces/java/tags/Xerces-J_2_8_0/NOTICE
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vieiro/incubator-netbeans netbeans-54-module-review-libs.xerces
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-netbeans/pull/113.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #113
----
commit 3a9f767d933afd9333de3f08f45cb56579efad95
Author: Antonio Vieiro <an...@vieiro.net>
Date: 2017-10-10T05:52:55Z
[NETBEANS-54] Module Review libs.xerces
- Updated maven coordinates for Xerces 2.8.0 (Apache 2).
- Added xerces notice from https://svn.apache.org/repos/asf/xerces/java/tags/Xerces-J_2_8_0/NOTICE
----
---
[GitHub] incubator-netbeans issue #113: [NETBEANS-54] Module Review libs.xerces
Posted by matthiasblaesing <gi...@git.apache.org>.
Github user matthiasblaesing commented on the issue:
https://github.com/apache/incubator-netbeans/pull/113
Please recheck this as this breaks the build. My local build breaks different than the protocol from travis, but reproducible. To check yourself, please run in the repository:
```
git clean -x -f
ant
```
The git clean part removes all files, that are not part of the repository. The downloaded file gets a different name and is can't be made available at build and compile time.
Hava a look at project.properties - this should do it:
```diff
# This patch file was generated by NetBeans IDE
# It uses platform neutral UTF-8 encoding and \n newlines.
--- a/libs.xerces/nbproject/project.properties
+++ b/libs.xerces/nbproject/project.properties
@@ -16,6 +16,6 @@
# under the License.
is.autoload=true
-release.external/xerces-2.8.0.jar=modules/ext/xerces-2.8.0.jar
+release.external/xercesImpl-2.8.0.jar=modules/ext/xerces-2.8.0.jar
module.jar.verifylinkageignores=org.apache.xerces.util.XMLCatalogResolver
spec.version.base=1.39.0
```
---
[GitHub] incubator-netbeans issue #113: [NETBEANS-54] Module Review libs.xerces
Posted by vieiro <gi...@git.apache.org>.
Github user vieiro commented on the issue:
https://github.com/apache/incubator-netbeans/pull/113
Thanks Matthias. If you ever happen to visit Madrid you know you have some free beers here.
---
[GitHub] incubator-netbeans issue #113: [NETBEANS-54] Module Review libs.xerces
Posted by vieiro <gi...@git.apache.org>.
Github user vieiro commented on the issue:
https://github.com/apache/incubator-netbeans/pull/113
Should be ready now. Sorry for the trouble. It would be nice getting a travis warning in case of build failure.
---
[GitHub] incubator-netbeans issue #113: [NETBEANS-54] Module Review libs.xerces
Posted by matthiasblaesing <gi...@git.apache.org>.
Github user matthiasblaesing commented on the issue:
https://github.com/apache/incubator-netbeans/pull/113
For the record: The content of the two binaries is identical, the files from maven central and the original netbeans file were zipped with different timestamps and differing directory order.
Diffoscope output is here: https://try.diffoscope.org/qayzdzqugqge.html
To check yourself: unzip both files and run a recursive diff over it.
---
[GitHub] incubator-netbeans issue #113: [NETBEANS-54] Module Review libs.xerces
Posted by matthiasblaesing <gi...@git.apache.org>.
Github user matthiasblaesing commented on the issue:
https://github.com/apache/incubator-netbeans/pull/113
I squashed your two commits together and merged this.
---
[GitHub] incubator-netbeans issue #113: [NETBEANS-54] Module Review libs.xerces
Posted by matthiasblaesing <gi...@git.apache.org>.
Github user matthiasblaesing commented on the issue:
https://github.com/apache/incubator-netbeans/pull/113
Your wish was already granted - the travis configuration was added to the repository literally hours ago. That's the reason I saw that. :-)
---
[GitHub] incubator-netbeans issue #113: [NETBEANS-54] Module Review libs.xerces
Posted by vieiro <gi...@git.apache.org>.
Github user vieiro commented on the issue:
https://github.com/apache/incubator-netbeans/pull/113
It would be nice getting a pair of beers in case of build success! :-D
---
[GitHub] incubator-netbeans pull request #113: [NETBEANS-54] Module Review libs.xerce...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/113
---