You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by alsorokin <gi...@git.apache.org> on 2015/05/12 16:34:37 UTC
[GitHub] cordova-js pull request: CB-8996 (Windows) Fixed invalid null comp...
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-js/pull/110
CB-8996 (Windows) Fixed invalid null comparison
https://issues.apache.org/jira/browse/CB-8996
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-js CB-8996
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-js/pull/110.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #110
----
commit aeb23a9270e2a276d8d6e1a408c8e8f37f9c58d5
Author: alsorokin <al...@akvelon.com>
Date: 2015-05-12T13:32:02Z
CB-8996 (Windows) Fixed invalid null comparison
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-js pull request: CB-8996 (Windows) Fixed invalid null comp...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-js/pull/110#issuecomment-101426677
Looks good!
@purplecabbage
risingj.com
On Tue, May 12, 2015 at 2:18 PM, Dmitry Blotsky <no...@github.com>
wrote:
> Merged, making it check explicitly for undefined and null, as per Jesse's
> note that 0 is a valid return value, and if(condition) wasn't sufficient.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cordova-js/pull/110#issuecomment-101424430>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-js pull request: CB-8996 (Windows) Fixed invalid null comp...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-js/pull/110#issuecomment-101424430
Merged, making it check explicitly for `undefined` and `null`, as per Jesse's note that 0 is a valid return value, and `if(condition)` wasn't sufficient.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-js pull request: CB-8996 (Windows) Fixed invalid null comp...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-js/pull/110#issuecomment-101466299
ultimately this was a failure of our use of jshint.
The original check of (undef != null) was fine, but jshint considered it an error ... which led to a fix which caused a real error.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-js pull request: CB-8996 (Windows) Fixed invalid null comp...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-js/pull/110
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-js pull request: CB-8996 (Windows) Fixed invalid null comp...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-js/pull/110#issuecomment-101361898
Status can be 0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org