You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "uranusjr (via GitHub)" <gi...@apache.org> on 2023/08/09 10:15:14 UTC

[GitHub] [airflow] uranusjr commented on a diff in pull request #30083: Account for change in UTC offset when performing next schedule calculations

uranusjr commented on code in PR #30083:
URL: https://github.com/apache/airflow/pull/30083#discussion_r1288265246


##########
newsfragments/30083.significant.rst:
##########
@@ -0,0 +1,8 @@
+Timezone-traversing non-fixed cron timetables properly accounts for timezone delta.
+
+Given a cron expression which results in an `interval` based schedule instead of a `fixed` schedule such as `0 9-16 * * *`, the Monday after a timezone change (e.g. Daylight Savings Time) the first job would be one hour offset.
+This was due to intentional code which accounted for timezone deltas, introduced after the switch to timetables (in `airflow>=2`).
+
+As an example, if operating in the `America/New_York` timezone when entering daylight savings time, the above schedule would result in a `10am` execution on Monday morning, instead of the previous `9am`.
+
+This functionality is now deprecated and reverted, so timezone-aware timetables will now run at the same time, e.g. a `9am` timetable will always run at `9am` local time.

Review Comment:
   A deprecation would imply the functionality is still available but disfavoured. This is not the case here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org