You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2022/06/17 16:56:16 UTC
[GitHub] [tinkerpop] lionelfleury opened a new pull request, #1716: fix version key race in Manifest
lionelfleury opened a new pull request, #1716:
URL: https://github.com/apache/tinkerpop/pull/1716
- use a more specific key to avoid race on version
- see: https://github.com/JanusGraph/janusgraph/discussions/3004
Signed-off-by: Lionel Fleury <li...@hotmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1716: TINKERPOP-2761: fix version key race in Manifest
Posted by GitBox <gi...@apache.org>.
spmallette commented on PR #1716:
URL: https://github.com/apache/tinkerpop/pull/1716#issuecomment-1161585397
> In the mentioned thread, it seems to read the version key from hbase jar
sorry - i read that thread but github didn't display the discussion in whole and i missed some additional comments
as i recall there isn't any standard to manifest files keys. rather than camel case of `tinkerpopVersion` could you please change it to `tinkerpop-version` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1716: fix version key race in Manifest
Posted by GitBox <gi...@apache.org>.
spmallette commented on PR #1716:
URL: https://github.com/apache/tinkerpop/pull/1716#issuecomment-1160747745
thanks for contributing, but i'm not sure i understand the discussion that was referenced and thus not sure i understand why the manifest version needs a special `tinkerpopVersion`. could you please explain further what you mean by a "race on version"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette merged pull request #1716: TINKERPOP-2761: fix version key race in Manifest
Posted by GitBox <gi...@apache.org>.
spmallette merged PR #1716:
URL: https://github.com/apache/tinkerpop/pull/1716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] lionelfleury commented on pull request #1716: fix version key race in Manifest
Posted by GitBox <gi...@apache.org>.
lionelfleury commented on PR #1716:
URL: https://github.com/apache/tinkerpop/pull/1716#issuecomment-1161398067
Sure. If we have multiple jars on the classpath, Manifests.read("version") might take the first resolved key with that name. Which might be from another library.
_In the mentioned thread, it seems to read the version key from hbase jar. _
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] lionelfleury commented on pull request #1716: TINKERPOP-2761: fix version key race in Manifest
Posted by GitBox <gi...@apache.org>.
lionelfleury commented on PR #1716:
URL: https://github.com/apache/tinkerpop/pull/1716#issuecomment-1161691805
done ✅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org