You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/10/21 12:40:08 UTC

[GitHub] [incubator-yunikorn-core] codecov[bot] commented on pull request #219: Yunikorn 352 - fixed max resource check and behavioural change

codecov[bot] commented on pull request #219:
URL: https://github.com/apache/incubator-yunikorn-core/pull/219#issuecomment-713539637


   # [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/219?src=pr&el=h1) Report
   > Merging [#219](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/219?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/e9ab51a96afc6a9ce9a320db800f514cf5e7ab50?el=desc) will **increase** coverage by `0.06%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/219/graphs/tree.svg?width=650&height=150&src=pr&token=SB9NrIi3Hy)](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/219?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #219      +/-   ##
   ==========================================
   + Coverage   60.90%   60.97%   +0.06%     
   ==========================================
     Files          67       67              
     Lines        5778     5788      +10     
   ==========================================
   + Hits         3519     3529      +10     
     Misses       2114     2114              
     Partials      145      145              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/219?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [pkg/common/configs/configvalidator.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/219/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9jb25maWdzL2NvbmZpZ3ZhbGlkYXRvci5nbw==) | `87.70% <100.00%> (+0.69%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/219?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/219?src=pr&el=footer). Last update [e9ab51a...fabda8d](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/219?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org