You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/08/05 13:50:12 UTC
[GitHub] [incubator-devlake] mindlesscloud opened a new pull request, #2692: fix: jira changelog.FromValue & changelog.ToValue
mindlesscloud opened a new pull request, #2692:
URL: https://github.com/apache/incubator-devlake/pull/2692
# Summary
fix #2691 [Bug][Jira] Incorrect values of issue_changelogs.from_value and issue_changelogs.to_value
### Does this close any open issues?
close #2691
### Screenshots
Include any relevant screenshots here.
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] narrowizard commented on a diff in pull request #2692: fix: jira changelog.FromValue & changelog.ToValue
Posted by GitBox <gi...@apache.org>.
narrowizard commented on code in PR #2692:
URL: https://github.com/apache/incubator-devlake/pull/2692#discussion_r939809249
##########
plugins/jira/tasks/status_collector.go:
##########
@@ -48,12 +48,14 @@ func CollectStatus(taskCtx core.SubTaskContext) error {
Table: RAW_STATUS_TABLE,
},
ApiClient: data.ApiClient,
- UrlTemplate: "api/2/status",
+ UrlTemplate: "api/2/statuses/search",
Review Comment:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] narrowizard commented on a diff in pull request #2692: fix: jira changelog.FromValue & changelog.ToValue
Posted by GitBox <gi...@apache.org>.
narrowizard commented on code in PR #2692:
URL: https://github.com/apache/incubator-devlake/pull/2692#discussion_r939809141
##########
plugins/jira/tasks/status_collector.go:
##########
@@ -48,12 +48,14 @@ func CollectStatus(taskCtx core.SubTaskContext) error {
Table: RAW_STATUS_TABLE,
},
ApiClient: data.ApiClient,
- UrlTemplate: "api/2/status",
+ UrlTemplate: "api/2/statuses/search",
Review Comment:
Api `api/2/statuses/search` is not existed in jira server version `v8.18.1#818001-sha1:765ecc5`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh merged pull request #2692: fix: jira changelog.FromValue & changelog.ToValue
Posted by GitBox <gi...@apache.org>.
klesh merged PR #2692:
URL: https://github.com/apache/incubator-devlake/pull/2692
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] narrowizard commented on a diff in pull request #2692: fix: jira changelog.FromValue & changelog.ToValue
Posted by GitBox <gi...@apache.org>.
narrowizard commented on code in PR #2692:
URL: https://github.com/apache/incubator-devlake/pull/2692#discussion_r939805727
##########
plugins/jira/tasks/issue_changelog_convertor.go:
##########
@@ -127,8 +136,14 @@ func ConvertIssueChangelogs(taskCtx core.SubTaskContext) error {
}
}
if row.Field == "status" {
- changelog.FromValue = getStdStatus(row.FromString)
- changelog.ToValue = getStdStatus(row.ToString)
+ changelog.FromValue = ticket.IN_PROGRESS
+ changelog.ToValue = ticket.IN_PROGRESS
+ if fromStatus, ok := statusMap[row.FromString]; ok {
+ changelog.FromValue = fromStatus.StatusCategory
Review Comment:
`getStdStatus(fromStatus.StatusCategory)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] narrowizard commented on a diff in pull request #2692: fix: jira changelog.FromValue & changelog.ToValue
Posted by GitBox <gi...@apache.org>.
narrowizard commented on code in PR #2692:
URL: https://github.com/apache/incubator-devlake/pull/2692#discussion_r939805872
##########
plugins/jira/tasks/issue_changelog_convertor.go:
##########
@@ -127,8 +136,14 @@ func ConvertIssueChangelogs(taskCtx core.SubTaskContext) error {
}
}
if row.Field == "status" {
- changelog.FromValue = getStdStatus(row.FromString)
- changelog.ToValue = getStdStatus(row.ToString)
+ changelog.FromValue = ticket.IN_PROGRESS
+ changelog.ToValue = ticket.IN_PROGRESS
+ if fromStatus, ok := statusMap[row.FromString]; ok {
+ changelog.FromValue = fromStatus.StatusCategory
+ }
+ if toStatus, ok := statusMap[row.ToString]; ok {
+ changelog.ToValue = toStatus.StatusCategory
Review Comment:
`getStdStatus(toStatus.StatusCategory)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org