You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by "elharo (via GitHub)" <gi...@apache.org> on 2026/08/25 11:03:45 UTC

Re: [PR] [MASSEMBLY-1031] Respect dependency mediation when resolving dependencySets [maven-assembly-plugin]

elharo commented on code in PR #1327:
URL: https://github.com/apache/maven-assembly-plugin/pull/1327#discussion_r3852310265


##########
src/it/projects/dependency-sets/massembly-1008/verify.groovy:
##########
@@ -19,18 +19,14 @@
 
 import java.io.*;
 
+// guava is absent from the runtime dependencySet: the nearer test-scoped guava 32.0.0-jre wins

Review Comment:
   I'm not at all sure this is what we want. It seems to me we should include guava in the assembly since it is used in non-test scope, but the version selected should come from the nearer test scoped guava. I could be misreading this, but that's my initial thought.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org