You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by surajpindoria <gi...@git.apache.org> on 2015/09/01 01:37:10 UTC
[GitHub] cordova-plugin-vibration pull request: [CB-7966] Add cordova-plugi...
GitHub user surajpindoria opened a pull request:
https://github.com/apache/cordova-plugin-vibration/pull/37
[CB-7966] Add cordova-plugin-vibration support for browser platform
The previous imple
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/surajpindoria/cordova-plugin-vibration browserSupport
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-vibration/pull/37.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #37
----
commit aa9835a71bc12e62d4520ac575de74a4e2790c84
Author: Suraj Pindoria <su...@yahoo.com>
Date: 2015-08-31T19:00:51Z
[CB-7966] Add cordova-plugin-vibration support for browser platform
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-vibration pull request: [CB-7966] Add cordova-plugi...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-vibration/pull/37#issuecomment-136822984
This is not a proxy, this is a clobbers.
You can remove your call to add the proxy and I would rename the file to just be vibration.js
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-vibration pull request: [CB-7966] Add cordova-plugi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-vibration/pull/37
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org