You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/21 18:26:30 UTC

[GitHub] [airflow] ryanahamilton opened a new pull request #11725: Refactor "loading" state of DAGs view to remove visual jank

ryanahamilton opened a new pull request #11725:
URL: https://github.com/apache/airflow/pull/11725


   This fixes the visual "jank" seen when loading the DAGs (home) view. Most of the unwanted shifting was being caused by the loading GIF images being shown briefly in the table header. This caused table cells to shift vertically and horizontally. The implementation was also a bit inconsistent in that it showed a loading state in two column headers ("Recent Tasks", "DAG Runs") and then in the individual cells of another ("Last Run"). I've remedied that by using the same placement for all three.
   
   I've moved the new "loading dots" pattern (CSS only, no images) introduced in #11534 to a macro file so that it could be repurposed here as well. 
   
   
   **Before:**
   
   ![Screen Recording 2020-10-21 at 02 05 15 PM](https://user-images.githubusercontent.com/3267/96759894-9e85cd80-13a6-11eb-95db-dd5d3ce60fa5.gif)
   
   **After:**
   
   ![Screen Recording 2020-10-21 at 02 23 09 PM](https://user-images.githubusercontent.com/3267/96766389-01786400-13a9-11eb-8736-c2c31bee4044.gif)
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil merged pull request #11725: Refactor "loading" state of DAGs view to remove visual jank

Posted by GitBox <gi...@apache.org>.

kaxil merged pull request #11725:
URL: https://github.com/apache/airflow/pull/11725


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org