You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by SolidWallOfCode <gi...@git.apache.org> on 2015/05/31 22:40:21 UTC
[GitHub] trafficserver pull request: TS-3650: Track configuration variable ...
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/206
TS-3650: Track configuration variable source.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SolidWallOfCode/trafficserver ts-3650
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/206.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #206
----
commit 9d2a62958861ba4aed197aa6c9c028687dbff838
Author: Alan M. Carroll <am...@apache.org>
Date: 2015-05-29T21:09:52Z
TS-3650: Track configuration variable source.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3650: Track configuration variable ...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode closed the pull request at:
https://github.com/apache/trafficserver/pull/206
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3650: Track configuration variable ...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/206#issuecomment-107280577
I don't have any particular thoughts on this, other than if we do this, we also add an API to query into this "source" of a particular config. E.g. TSMgmtSourceGet(). I'd be curious as to what @jpeach thinks about this, since he's knee deep in all this lib records stuff.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3650: Track configuration variable ...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/206#issuecomment-107638604
Yes, I had the same conflict about ``RECS`` ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3650: Track configuration variable ...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/206#issuecomment-107638211
The chat concensus seemed to be to change this to NULL, DEFAULT, EXPLICIT, ENV. I'll change "SRC" to "SOURCE" as well - I was tempted to have "RECS" which would be more consistent with the other REC values but that seemed even worse scanning.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3650: Track configuration variable ...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/206#issuecomment-107628793
The ``REC_SRC`` constants scan poorly, I think I'd prefer ``REC_SOURCE``. ``REC_SRC_NONE`` should be called ``REC_SOURCE_NULL`` to be consistent with other naming. There's some semantic confusion about what ``REC_SRC_DEFAULT`` means. When ``traffic_manager`` sets variables, I don't think they should be considered defaults.
I am sympathetic to @sudheerv's concerns about how useful this is. The distinction between "hard-coded default" and "everything else" is clear, but this change is attempting to track various nuances that are much murkier.
Does ``DiagsConfig::RegisterDiagConfig`` really have to register everything? I expect that that superfluous now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3650: Track configuration variable ...
Posted by sudheerv <gi...@git.apache.org>.
Github user sudheerv commented on the pull request:
https://github.com/apache/trafficserver/pull/206#issuecomment-107253803
A config set via traffic_line gets added to records.config as well, so the source of the config changes after a TS restart. Depending on how that info is used, the behavior may be affected after a restart. Note that the config file doesn't get updated when set via a plugin API, so, this looks very inconsistent and unreliable to me and may result in more bugs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3650: Track configuration variable ...
Posted by sudheerv <gi...@git.apache.org>.
Github user sudheerv commented on the pull request:
https://github.com/apache/trafficserver/pull/206#issuecomment-107653612
I don't think there was a consensus yet (at least, not from my side). AFAIK, my question above on persisting the source as traffic_line was not addressed and without making that information consistent, I am -1 on this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3650: Track configuration variable ...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/206#issuecomment-107664507
There's no way to know whether a metric was set by ``traffic_line``. The best you can do is to say whether a metric was set by a specific API, but that's complex and low value IMHO, and as you pointed out above, that information is lost when the configuration is persisted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---