You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by ProjectMoon <gi...@git.apache.org> on 2016/01/22 11:11:28 UTC
[GitHub] cloudstack pull request: Refactor system VM default network creati...
GitHub user ProjectMoon opened a pull request:
https://github.com/apache/cloudstack/pull/1359
Refactor system VM default network creation
Two small commits which moves the retrieval of the default network for the console proxy and the SSVM into a separate protected method. It's a small change that makes the code more readable/maintainable and also makes the class more suitable for overriding should one want to do this. It's forward-ported from our 4.2 branch.
No new tests since this should not change any functionality, and thus should be covered by the existing unit tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greenqloud/cloudstack pr-refactor-system-vm-network-creation
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1359.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1359
----
commit 3da5d2054acd0cdbc9f71bda3309ba7783a87a90
Author: jeff <je...@greenqloud.com>
Date: 2016-01-22T10:04:57Z
GQSS-44: Refactor console proxy default network retrieval.
It is now in a separate method for more readability and flexibility.
commit 7f6742018b8c53851c40087c7e621eafc1c459f1
Author: jeff <je...@greenqloud.com>
Date: 2016-01-22T10:07:01Z
GQSS-44: Refactor ssvm default network retrieval.
It's now in a separate method to increase readability and flexibility.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Refactor system VM default network creati...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1359#issuecomment-173872832
@ProjectMoon Indeed! :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Refactor system VM default network creati...
Posted by ProjectMoon <gi...@git.apache.org>.
Github user ProjectMoon closed the pull request at:
https://github.com/apache/cloudstack/pull/1359
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Refactor system VM default network creati...
Posted by ProjectMoon <gi...@git.apache.org>.
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1359#issuecomment-173872098
OK. So just to be sure: it's oldest supported maintenance release for bug fixes and then master for any new features/refactoring?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Refactor system VM default network creati...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1359#issuecomment-173869657
Hi @ProjectMoon
Could you please create you PR against Master. If that's a refactor does not really make sense to create the PR against 4.6 because we are already releasing 4.7.1 and 4.8.0.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---