[GitHub] [james-project] Arsnael commented on a diff in pull request #1495: [FIX] Shared mailbox revocation rights should be visible in Mailbox/C…

["Arsnael (via GitHub)" <gi...@apache.org>]

Arsnael commented on code in PR #1495:
URL: https://github.com/apache/james-project/pull/1495#discussion_r1142832779


##########
server/data/data-jmap/src/main/java/org/apache/james/jmap/api/change/MailboxChange.java:
##########
@@ -226,7 +226,21 @@ public List<JmapChange> fromMailboxACLUpdated(MailboxACLUpdated mailboxACLUpdate
                     .delegated()
                     .build());
 
-            return Stream.concat(Stream.of(ownerChange), shareeChanges)
+            Stream<MailboxChange> deletionChanges = mailboxACLUpdated.getAclDiff()
+                .removedEntries()
+                .filter(entry -> entry.getKey().getNameType().equals(MailboxACL.NameType.user))
+                .filter(entry -> !entry.getKey().isNegative())
+                .map(entry -> MailboxChange.builder()
+                    .accountId(AccountId.fromString(entry.getKey().getName()))
+                    .state(stateFactory.generate())
+                    .date(now)
+                    .isCountChange(false)
+                    .destroyed(ImmutableList.of(mailboxACLUpdated.getMailboxId()))

Review Comment:
   Are you sure that with just updated though the client will understand that the user is not linked to the shared mailbox anymore?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org