[GitHub] [rocketmq-externals] Git-Yang commented on a change in pull request #701: [#697] Synchronize the latest local position between worker nodes.

[GitBox <gi...@apache.org>]

Git-Yang commented on a change in pull request #701:
URL: https://github.com/apache/rocketmq-externals/pull/701#discussion_r693687120



##########
File path: rocketmq-connect/rocketmq-connect-runtime/src/main/java/org/apache/rocketmq/connect/runtime/service/PositionManagementServiceImpl.java
##########
@@ -154,7 +178,6 @@ public void onCompletion(Throwable error, String key, Map<ByteBuffer, ByteBuffer
             boolean changed = false;
             switch (PositionChangeEnum.valueOf(key)) {
                 case ONLINE_KEY:
-                    mergePositionInfo(result);

Review comment:
          The offset of the starting node generally lags behind that of the existing node. If the node is restarted after being stopped for a period of time, direct merging may overwrite the latest offset, resulting in data duplication. 
      In addition, the offset of the starting node has been synchronized to the corresponding topic, and other nodes have actually obtained all the offsets, so I think it is not necessary to directly merge the offsets of the starting node.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org