You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/03/06 20:05:18 UTC
Re: Review Request 65720: Windows: Fixed location of imported
libraries for Ninja.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65720/
-----------------------------------------------------------
(Updated March 6, 2018, 12:05 p.m.)
Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and Joseph Wu.
Changes
-------
Set `IMPORTED_LOCATION` for Ninja on Windows explicitly rather than with a hack.
Bugs: MESOS-8599
https://issues.apache.org/jira/browse/MESOS-8599
Repository: mesos
Description (updated)
-------
The Ninja generator does not emit binaries to "Debug" or "Release"
folders (unlike the Visual Studio generator), as it is not a
multi-configuration generator. To fix this, we explicitly set the
`IMPORTED_LOCATION` instead of `IMPORTED_LOCATION_(DEBUG|RELEASE)`
when using the Ninja generator on Windows. This does not reuse the
location used on non-Windows platforms, as they're not consistent
despite the generator being the same.
Diffs (updated)
-----
3rdparty/CMakeLists.txt da605707b89bbe9b3db9e60bc0b0a26dac46e56e
Diff: https://reviews.apache.org/r/65720/diff/2/
Changes: https://reviews.apache.org/r/65720/diff/1-2/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 65720: Windows: Fixed location of imported
libraries for Ninja.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65720/
-----------------------------------------------------------
(Updated March 7, 2018, 1:44 p.m.)
Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and Joseph Wu.
Bugs: MESOS-8599
https://issues.apache.org/jira/browse/MESOS-8599
Repository: mesos
Description (updated)
-------
The Ninja generator does not emit binaries to "Debug" or "Release"
folders (unlike the Visual Studio generator), as it is not a
multi-configuration generator. To fix this, we explicitly set the
`IMPORTED_LOCATION` instead of `IMPORTED_LOCATION_(DEBUG|RELEASE)`
when using the Ninja generator on Windows. This does not reuse the
location used on non-Windows platforms, as they're not consistent
despite the generator being the same.
This also simplifies the `GET_BYPRODUCTS` function to set `BYPRODUCTS`
to an empty string when the generator is not Ninja, as it should be a
no-op for other generators.
Diffs (updated)
-----
3rdparty/CMakeLists.txt da605707b89bbe9b3db9e60bc0b0a26dac46e56e
Diff: https://reviews.apache.org/r/65720/diff/4/
Changes: https://reviews.apache.org/r/65720/diff/3-4/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 65720: Windows: Fixed location of imported
libraries for Ninja.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65720/
-----------------------------------------------------------
(Updated March 7, 2018, 12:54 p.m.)
Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and Joseph Wu.
Changes
-------
Updated per review comments.
Bugs: MESOS-8599
https://issues.apache.org/jira/browse/MESOS-8599
Repository: mesos
Description
-------
The Ninja generator does not emit binaries to "Debug" or "Release"
folders (unlike the Visual Studio generator), as it is not a
multi-configuration generator. To fix this, we explicitly set the
`IMPORTED_LOCATION` instead of `IMPORTED_LOCATION_(DEBUG|RELEASE)`
when using the Ninja generator on Windows. This does not reuse the
location used on non-Windows platforms, as they're not consistent
despite the generator being the same.
Diffs (updated)
-----
3rdparty/CMakeLists.txt da605707b89bbe9b3db9e60bc0b0a26dac46e56e
Diff: https://reviews.apache.org/r/65720/diff/3/
Changes: https://reviews.apache.org/r/65720/diff/2-3/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 65720: Windows: Fixed location of imported
libraries for Ninja.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65720/#review198732
-----------------------------------------------------------
PASS: Mesos patch 65720 was successfully built and tested.
Reviews applied: `['65719', '65721', '65720']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65720
- Mesos Reviewbot Windows
On March 6, 2018, 12:05 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65720/
> -----------------------------------------------------------
>
> (Updated March 6, 2018, 12:05 p.m.)
>
>
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and Joseph Wu.
>
>
> Bugs: MESOS-8599
> https://issues.apache.org/jira/browse/MESOS-8599
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Ninja generator does not emit binaries to "Debug" or "Release"
> folders (unlike the Visual Studio generator), as it is not a
> multi-configuration generator. To fix this, we explicitly set the
> `IMPORTED_LOCATION` instead of `IMPORTED_LOCATION_(DEBUG|RELEASE)`
> when using the Ninja generator on Windows. This does not reuse the
> location used on non-Windows platforms, as they're not consistent
> despite the generator being the same.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt da605707b89bbe9b3db9e60bc0b0a26dac46e56e
>
>
> Diff: https://reviews.apache.org/r/65720/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 65720: Windows: Fixed location of imported
libraries for Ninja.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65720/#review198750
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65719, 65721, 65720]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 6, 2018, 8:05 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65720/
> -----------------------------------------------------------
>
> (Updated March 6, 2018, 8:05 p.m.)
>
>
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and Joseph Wu.
>
>
> Bugs: MESOS-8599
> https://issues.apache.org/jira/browse/MESOS-8599
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Ninja generator does not emit binaries to "Debug" or "Release"
> folders (unlike the Visual Studio generator), as it is not a
> multi-configuration generator. To fix this, we explicitly set the
> `IMPORTED_LOCATION` instead of `IMPORTED_LOCATION_(DEBUG|RELEASE)`
> when using the Ninja generator on Windows. This does not reuse the
> location used on non-Windows platforms, as they're not consistent
> despite the generator being the same.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt da605707b89bbe9b3db9e60bc0b0a26dac46e56e
>
>
> Diff: https://reviews.apache.org/r/65720/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 65720: Windows: Fixed location of imported
libraries for Ninja.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On March 7, 2018, 4:21 a.m., Benjamin Bannier wrote:
> > 3rdparty/CMakeLists.txt
> > Lines 158-160 (original), 158-165 (patched)
> > <https://reviews.apache.org/r/65720/diff/2/?file=1971993#file1971993line158>
> >
> > The paths for vs look more specific to me, so I wonder whether it maes sense to either turn the logic around (`if (VC) ... else ()`), or use `elseif` instead of a catch all `else`.
> >
> > Here and below.
I'm not following. There are only two supported generators on Windows: VS and Ninja. Flipping this `if` around is just style that doesn't change anything. (NOTE: This is all in the WIN32 block.)
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65720/#review198783
-----------------------------------------------------------
On March 6, 2018, 12:05 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65720/
> -----------------------------------------------------------
>
> (Updated March 6, 2018, 12:05 p.m.)
>
>
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and Joseph Wu.
>
>
> Bugs: MESOS-8599
> https://issues.apache.org/jira/browse/MESOS-8599
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Ninja generator does not emit binaries to "Debug" or "Release"
> folders (unlike the Visual Studio generator), as it is not a
> multi-configuration generator. To fix this, we explicitly set the
> `IMPORTED_LOCATION` instead of `IMPORTED_LOCATION_(DEBUG|RELEASE)`
> when using the Ninja generator on Windows. This does not reuse the
> location used on non-Windows platforms, as they're not consistent
> despite the generator being the same.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt da605707b89bbe9b3db9e60bc0b0a26dac46e56e
>
>
> Diff: https://reviews.apache.org/r/65720/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 65720: Windows: Fixed location of imported
libraries for Ninja.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65720/#review198783
-----------------------------------------------------------
3rdparty/CMakeLists.txt
Lines 158-160 (original), 158-165 (patched)
<https://reviews.apache.org/r/65720/#comment279021>
The paths for vs look more specific to me, so I wonder whether it maes sense to either turn the logic around (`if (VC) ... else ()`), or use `elseif` instead of a catch all `else`.
Here and below.
3rdparty/CMakeLists.txt
Lines 229 (patched)
<https://reviews.apache.org/r/65720/#comment279023>
Unneeded empty line here?
3rdparty/CMakeLists.txt
Lines 230-239 (patched)
<https://reviews.apache.org/r/65720/#comment279022>
Ditto.
3rdparty/CMakeLists.txt
Lines 319-331 (patched)
<https://reviews.apache.org/r/65720/#comment279024>
Ditto.
3rdparty/CMakeLists.txt
Lines 396-399 (original), 421-430 (patched)
<https://reviews.apache.org/r/65720/#comment279025>
Ditto.
3rdparty/CMakeLists.txt
Lines 441-444 (original), 472-481 (patched)
<https://reviews.apache.org/r/65720/#comment279026>
Ditto.
3rdparty/CMakeLists.txt
Lines 557-566 (patched)
<https://reviews.apache.org/r/65720/#comment279027>
Ditto.
3rdparty/CMakeLists.txt
Lines 648-660 (patched)
<https://reviews.apache.org/r/65720/#comment279028>
Ditto.
3rdparty/CMakeLists.txt
Lines 725-733 (patched)
<https://reviews.apache.org/r/65720/#comment279029>
Ditto.
3rdparty/CMakeLists.txt
Lines 796-804 (patched)
<https://reviews.apache.org/r/65720/#comment279030>
Ditto.
3rdparty/CMakeLists.txt
Lines 872-881 (patched)
<https://reviews.apache.org/r/65720/#comment279031>
Ditto.
3rdparty/CMakeLists.txt
Lines 941-949 (patched)
<https://reviews.apache.org/r/65720/#comment279032>
Ditto.
- Benjamin Bannier
On March 6, 2018, 9:05 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65720/
> -----------------------------------------------------------
>
> (Updated March 6, 2018, 9:05 p.m.)
>
>
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and Joseph Wu.
>
>
> Bugs: MESOS-8599
> https://issues.apache.org/jira/browse/MESOS-8599
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Ninja generator does not emit binaries to "Debug" or "Release"
> folders (unlike the Visual Studio generator), as it is not a
> multi-configuration generator. To fix this, we explicitly set the
> `IMPORTED_LOCATION` instead of `IMPORTED_LOCATION_(DEBUG|RELEASE)`
> when using the Ninja generator on Windows. This does not reuse the
> location used on non-Windows platforms, as they're not consistent
> despite the generator being the same.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt da605707b89bbe9b3db9e60bc0b0a26dac46e56e
>
>
> Diff: https://reviews.apache.org/r/65720/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 65720: Windows: Fixed location of imported
libraries for Ninja.
Posted by Akash Gupta <ak...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65720/#review198748
-----------------------------------------------------------
Ship it!
Ship It!
- Akash Gupta
On March 6, 2018, 8:05 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65720/
> -----------------------------------------------------------
>
> (Updated March 6, 2018, 8:05 p.m.)
>
>
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and Joseph Wu.
>
>
> Bugs: MESOS-8599
> https://issues.apache.org/jira/browse/MESOS-8599
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Ninja generator does not emit binaries to "Debug" or "Release"
> folders (unlike the Visual Studio generator), as it is not a
> multi-configuration generator. To fix this, we explicitly set the
> `IMPORTED_LOCATION` instead of `IMPORTED_LOCATION_(DEBUG|RELEASE)`
> when using the Ninja generator on Windows. This does not reuse the
> location used on non-Windows platforms, as they're not consistent
> despite the generator being the same.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt da605707b89bbe9b3db9e60bc0b0a26dac46e56e
>
>
> Diff: https://reviews.apache.org/r/65720/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>