You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by an...@apache.org on 2017/01/09 09:39:00 UTC

[1/3] libcloud git commit: fix issue where port is not propagated down to connection URL

Repository: libcloud
Updated Branches:
  refs/heads/trunk 10f987905 -> c8ba7fe0b


fix issue where port is not propagated down to connection URL


Project: http://git-wip-us.apache.org/repos/asf/libcloud/repo
Commit: http://git-wip-us.apache.org/repos/asf/libcloud/commit/6261cc5f
Tree: http://git-wip-us.apache.org/repos/asf/libcloud/tree/6261cc5f
Diff: http://git-wip-us.apache.org/repos/asf/libcloud/diff/6261cc5f

Branch: refs/heads/trunk
Commit: 6261cc5fbb436283df4bb4265f01d4eeabb6c80e
Parents: 10f9879
Author: Anthony Shaw <an...@apache.org>
Authored: Mon Jan 9 17:19:34 2017 +1100
Committer: Anthony Shaw <an...@apache.org>
Committed: Mon Jan 9 17:19:34 2017 +1100

----------------------------------------------------------------------
 libcloud/httplib_ssl.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/libcloud/blob/6261cc5f/libcloud/httplib_ssl.py
----------------------------------------------------------------------
diff --git a/libcloud/httplib_ssl.py b/libcloud/httplib_ssl.py
index f47e491..6aff1b3 100644
--- a/libcloud/httplib_ssl.py
+++ b/libcloud/httplib_ssl.py
@@ -163,9 +163,10 @@ class LibcloudConnection(LibcloudBaseConnection):
     response = None
 
     def __init__(self, host, port, **kwargs):
-        self.host = '{0}://{1}'.format(
+        self.host = '{0}://{1}{2}'.format(
             'https' if port == 443 else 'http',
-            host
+            host,
+            ":{0}".format(port) if port not in (80, 443) else ""
         )
         # Support for HTTP proxy
         proxy_url_env = os.environ.get(HTTP_PROXY_ENV_VARIABLE_NAME, None)


[2/3] libcloud git commit: add test for port propagation issue

Posted by an...@apache.org.
add test for port propagation issue


Project: http://git-wip-us.apache.org/repos/asf/libcloud/repo
Commit: http://git-wip-us.apache.org/repos/asf/libcloud/commit/8b3b1cbc
Tree: http://git-wip-us.apache.org/repos/asf/libcloud/tree/8b3b1cbc
Diff: http://git-wip-us.apache.org/repos/asf/libcloud/diff/8b3b1cbc

Branch: refs/heads/trunk
Commit: 8b3b1cbcf650df843d7e1329db7f0572883dd67c
Parents: 6261cc5
Author: Anthony Shaw <an...@apache.org>
Authored: Mon Jan 9 19:23:57 2017 +1100
Committer: Anthony Shaw <an...@apache.org>
Committed: Mon Jan 9 19:23:57 2017 +1100

----------------------------------------------------------------------
 libcloud/test/test_connection.py | 10 ++++++++++
 1 file changed, 10 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/libcloud/blob/8b3b1cbc/libcloud/test/test_connection.py
----------------------------------------------------------------------
diff --git a/libcloud/test/test_connection.py b/libcloud/test/test_connection.py
index b4743c3..c6c770d 100644
--- a/libcloud/test/test_connection.py
+++ b/libcloud/test/test_connection.py
@@ -99,6 +99,16 @@ class BaseConnectionClassTestCase(unittest.TestCase):
         self.assertEqual(conn.proxy_host, '127.0.0.5')
         self.assertEqual(conn.proxy_port, 3128)
 
+    def test_connection_to_unusual_port(self):
+        conn = LibcloudConnection(host='localhost', port=8080)
+        self.assertEqual(conn.proxy_scheme, None)
+        self.assertEqual(conn.proxy_host, None)
+        self.assertEqual(conn.proxy_port, None)
+        self.assertEqual(conn.host, 'http://localhost:8080')
+
+        conn = LibcloudConnection(host='localhost', port=80)
+        self.assertEqual(conn.host, 'http://localhost')
+
 
 class ConnectionClassTestCase(unittest.TestCase):
     def setUp(self):


[3/3] libcloud git commit: changes for #928 and #971

Posted by an...@apache.org.
changes for #928 and #971


Project: http://git-wip-us.apache.org/repos/asf/libcloud/repo
Commit: http://git-wip-us.apache.org/repos/asf/libcloud/commit/c8ba7fe0
Tree: http://git-wip-us.apache.org/repos/asf/libcloud/tree/c8ba7fe0
Diff: http://git-wip-us.apache.org/repos/asf/libcloud/diff/c8ba7fe0

Branch: refs/heads/trunk
Commit: c8ba7fe0baaa615c205653bb36ab3b809cadc9f3
Parents: 8b3b1cb
Author: Anthony Shaw <an...@apache.org>
Authored: Mon Jan 9 20:38:52 2017 +1100
Committer: Anthony Shaw <an...@apache.org>
Committed: Mon Jan 9 20:38:52 2017 +1100

----------------------------------------------------------------------
 CHANGES.rst | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/libcloud/blob/c8ba7fe0/CHANGES.rst
----------------------------------------------------------------------
diff --git a/CHANGES.rst b/CHANGES.rst
index 8374149..fafcb2d 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -1,6 +1,20 @@
 \ufeffChangelog
 =========
 
+Changes in current version of Apache Libcloud
+---------------------------------------------
+
+Common
+~~~~~~
+
+- Introduction of the requests package as the mechanism for making HTTP requests for all drivers
+  [GITHUB-928]
+  (Anthony Shaw)
+
+- Fix bug where custom port would not get propagated to connection
+  [GITHUB-971]
+  (Anthony Shaw)
+
 
 Changes in Apache Libcloud 1.5.0
 --------------------------------