[GitHub] [airflow] potiuk commented on a diff in pull request #29694: `GoogleDriveHook`: Fixing log message + adding more verbose documentation

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk commented on code in PR #29694:
URL: https://github.com/apache/airflow/pull/29694#discussion_r1125569580


##########
airflow/providers/google/suite/hooks/drive.py:
##########
@@ -243,8 +292,21 @@ def upload_file(
             .create(body=file_metadata, media_body=media, fields="id", supportsAllDrives=True)
             .execute(num_retries=self.num_retries)
         )
-        self.log.info("File %s uploaded to gdrive://%s.", local_location, remote_location)
-        return file.get("id")
+        file_id = file.get("id")
+
+        upload_location = remote_location
+
+        if folder_id != "root":
+            try:
+                upload_location = self._resolve_file_path(folder_id)
+            except GoogleApiClientError as e:
+                self.log.warning("A problem has been encountered when trying to resolve file path: ", e)
+
+        if show_full_target_path:
+            self.log.info("File %s uploaded to gdrive://%s.", local_location, upload_location)
+        else:
+            self.log.info("File %s has been uploaded successfully to gdrive", local_location)

Review Comment:
   @eladkal -> this is what I asked for as an escape hatch. The problem is that there might be potentially problems that might lead to  exception raised when "_resolve_file_path". is called (I thought for example if you have no permission to read the whole path. GDrive is not a "normal" filesystem and traversing up the directory might in some cases turn problematic. Since we ONLY need that to log the path, this is something that we might want to disable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org