[GitHub] [incubator-mxnet] larroy commented on a change in pull request #14728: [MXNET-1386] fix for shape mismatch

[GitBox <gi...@apache.org>]

larroy commented on a change in pull request #14728: [MXNET-1386] fix for shape mismatch
URL: https://github.com/apache/incubator-mxnet/pull/14728#discussion_r297427520
 
 

 ##########
 File path: src/executor/graph_executor.cc
 ##########
 @@ -558,20 +558,31 @@ void GraphExecutor::InitArguments(const nnvm::IndexedGraph& idx,
                                   const std::unordered_set<std::string>& shared_arg_names,
                                   const Executor* shared_exec,
                                   std::unordered_map<std::string, NDArray>* shared_buffer,
+                                  std::vector<std::string>* in_names,
                                   std::vector<NDArray>* in_arg_vec,
                                   std::vector<NDArray>* arg_grad_vec,
                                   std::vector<NDArray>* aux_state_vec) {
+  // build name/index map for graph input nodes
+  std::map<std::string, uint32_t> inv_name_map;
 
 Review comment:
   do you need ordering? could be unordered_map as is amortized constant vs log N

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services