You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "rawwar (via GitHub)" <gi...@apache.org> on 2024/06/04 04:48:41 UTC
[I] Support `limit` and `offset` parameters for List task instances (batch) endpoint [airflow]
rawwar opened a new issue, #40038:
URL: https://github.com/apache/airflow/issues/40038
### Description
As of now, `limit` and `offset` are not supported for [List task instances (batch)](https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html#operation/get_mapped_task_instances) endpoint. Supporting them will help users fetch data in batches
### Use case/motivation
Limit and offset are available for List DAGs. Having this feature for listing task instances will help manage the amount of data retrieved
### Related issues
NA
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support `limit` and `offset` parameters for List task instances (batch) endpoint [airflow]
Posted by "yuxian0908 (via GitHub)" <gi...@apache.org>.
yuxian0908 commented on issue #40038:
URL: https://github.com/apache/airflow/issues/40038#issuecomment-2309174585
Hi @ShakaibKhan, I’m planning to submit my first PR and was wondering if I could take on this issue? (If you’re not currently working on it, of course.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support `limit` and `offset` parameters for List task instances (batch) endpoint [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on issue #40038:
URL: https://github.com/apache/airflow/issues/40038#issuecomment-2150701418
> @shahar1 , [Documentation](https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html#operation/get_task_instances_batch) does not mention about `page_offset` and `page_limit`. But, I will try to use them and see if they work
I misread as DAG runs and not task instances, apologies :)
Maybe it can be implemented similarly though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support `limit` and `offset` parameters for List task instances (batch) endpoint [airflow]
Posted by "ShakaibKhan (via GitHub)" <gi...@apache.org>.
ShakaibKhan commented on issue #40038:
URL: https://github.com/apache/airflow/issues/40038#issuecomment-2211463427
Looks like [page_limit and page_offset](https://github.com/apache/airflow/blob/2eda7376f4c27df82f0cafba7699bcc46c3fcd05/airflow/api_connexion/schemas/task_instance_schema.py#L106) are already in the endpoint schema its just not used in the endpoint. I have added and tested the changes to the endpoint locally. I am working on adding some unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support `limit` and `offset` parameters for List task instances (batch) endpoint [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on issue #40038:
URL: https://github.com/apache/airflow/issues/40038#issuecomment-2148161634
There are `page_offset` and `page_limit` params, don't they satisfy your requirements?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support `limit` and `offset` parameters for List task instances (batch) endpoint [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on issue #40038:
URL: https://github.com/apache/airflow/issues/40038#issuecomment-2160453088
> I can try adding this to the task instance batch endpoint. I think its just passing the `limit` and `offset` into the body and adding them to the task instance query. If no one else is addressing this I will assign it to myself.
I assigned this task for you, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support `limit` and `offset` parameters for List task instances (batch) endpoint [airflow]
Posted by "rawwar (via GitHub)" <gi...@apache.org>.
rawwar commented on issue #40038:
URL: https://github.com/apache/airflow/issues/40038#issuecomment-2150486604
@shahar1 , [Documentation](https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html#operation/get_task_instances_batch) does not mention about `page_offset` and `page_limit`. But, I will try to use them and see if they work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support `limit` and `offset` parameters for List task instances (batch) endpoint [airflow]
Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy closed issue #40038: Support `limit` and `offset` parameters for List task instances (batch) endpoint
URL: https://github.com/apache/airflow/issues/40038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support `limit` and `offset` parameters for List task instances (batch) endpoint [airflow]
Posted by "ShakaibKhan (via GitHub)" <gi...@apache.org>.
ShakaibKhan commented on issue #40038:
URL: https://github.com/apache/airflow/issues/40038#issuecomment-2158596070
I can try adding this to the task instance batch endpoint. I think its just passing the `limit` and `offset` into the body and adding them to the task instance query. If no one else is addressing this I will assign it to myself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org