You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bloodhound.apache.org by James Wood <ja...@wandisco.com> on 2013/08/01 14:37:46 UTC

Milestone owners

I found this in bhtheme/templates/bh_milestone_view.html (line 54):

  <py:def function="milestone_owner()">
    <py:choose>
      <py:when test="milestone.owner">
        Assigned to
        <a href="${href.query(owner=milestone.owner, status='!closed',
            milestone=milestone.name, order='priority')}">${milestone.name
}</a>
      </py:when>
      <py:otherwise>&nbsp;</py:otherwise>
    </py:choose>
  </py:def>

I have two questions:
1) ${milestone.name} looks wrong. It makes the output something like
"Assigned to milestone1". I guess it was supposed to be ${milestone.owner},
which gives "Assigned to admin".
2) Currently, milestones don't have owners. Are there plans to give them
owners? If not, this code is unused.

Thanks for reading,
James

Re: Milestone owners

Posted by Ryan Ollos <ry...@wandisco.com>.
On Thu, Aug 1, 2013 at 5:52 AM, Matevž Bradač <ma...@digiverse.si> wrote:

>
> On 1. Aug, 2013, at 14:37, James Wood wrote:
>
> > I found this in bhtheme/templates/bh_milestone_view.html (line 54):
> >
> >  <py:def function="milestone_owner()">
> >    <py:choose>
> >      <py:when test="milestone.owner">
> >        Assigned to
> >        <a href="${href.query(owner=milestone.owner, status='!closed',
> >            milestone=milestone.name, order='priority')}">${
> milestone.name
> > }</a>
> >      </py:when>
> >      <py:otherwise>&nbsp;</py:otherwise>
> >    </py:choose>
> >  </py:def>
> >
> > I have two questions:
> > 1) ${milestone.name} looks wrong. It makes the output something like
> > "Assigned to milestone1". I guess it was supposed to be
> ${milestone.owner},
> > which gives "Assigned to admin".
> > 2) Currently, milestones don't have owners. Are there plans to give them
> > owners? If not, this code is unused.
>
> I think the code can be removed - milestones don't have owners, components
> do.
>

Code removed in [1511592].

Comment on this issue was made in
https://issues.apache.org/bloodhound/ticket/93#comment:41.

Thank you James and Matevž.

Re: Milestone owners

Posted by Matevž Bradač <ma...@digiverse.si>.
On 1. Aug, 2013, at 14:37, James Wood wrote:

> I found this in bhtheme/templates/bh_milestone_view.html (line 54):
> 
>  <py:def function="milestone_owner()">
>    <py:choose>
>      <py:when test="milestone.owner">
>        Assigned to
>        <a href="${href.query(owner=milestone.owner, status='!closed',
>            milestone=milestone.name, order='priority')}">${milestone.name
> }</a>
>      </py:when>
>      <py:otherwise>&nbsp;</py:otherwise>
>    </py:choose>
>  </py:def>
> 
> I have two questions:
> 1) ${milestone.name} looks wrong. It makes the output something like
> "Assigned to milestone1". I guess it was supposed to be ${milestone.owner},
> which gives "Assigned to admin".
> 2) Currently, milestones don't have owners. Are there plans to give them
> owners? If not, this code is unused.

I think the code can be removed - milestones don't have owners, components do.

> 
> Thanks for reading,
> James