You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/04/15 12:07:40 UTC
[GitHub] [calcite] yanlin-Lynn opened a new pull request #2400: [CALCITE-4584] Using function in partition by list of over window cause converting exception
yanlin-Lynn opened a new pull request #2400:
URL: https://github.com/apache/calcite/pull/2400
When disable the sql validator to expand identifier, using function expr in the partition by list of over window will cause exception. See [jira:CALCITE-4584](https://issues.apache.org/jira/browse/CALCITE-4584) for mode details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] yanlin-Lynn commented on pull request #2400: [CALCITE-4584] Using function in partition by list of over window cause converting exception
Posted by GitBox <gi...@apache.org>.
yanlin-Lynn commented on pull request #2400:
URL: https://github.com/apache/calcite/pull/2400#issuecomment-847478950
hi, @chunweilei , any more problem for this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] yanlin-Lynn merged pull request #2400: [CALCITE-4584] Using function in partition by list of over window cause converting exception
Posted by GitBox <gi...@apache.org>.
yanlin-Lynn merged pull request #2400:
URL: https://github.com/apache/calcite/pull/2400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] yanlin-Lynn commented on a change in pull request #2400: [CALCITE-4584] Using function in partition by list of over window cause converting exception
Posted by GitBox <gi...@apache.org>.
yanlin-Lynn commented on a change in pull request #2400:
URL: https://github.com/apache/calcite/pull/2400#discussion_r637646265
##########
File path: core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml
##########
@@ -7419,6 +7419,18 @@ from dept]]>
<![CDATA[
LogicalProject(EXPR$0=[COMPOSITE($0)])
LogicalTableScan(table=[[CATALOG, SALES, DEPT]])
+]]>
+ </Resource>
+ </TestCase>
+ <TestCase name="testFunctionExprInOver">
+ <Resource name="sql">
+ <![CDATA[select deptno, rank() over(partition by empno order by deptno) from emp]]>
+ </Resource>
Review comment:
Thanks for review. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] chunweilei commented on a change in pull request #2400: [CALCITE-4584] Using function in partition by list of over window cause converting exception
Posted by GitBox <gi...@apache.org>.
chunweilei commented on a change in pull request #2400:
URL: https://github.com/apache/calcite/pull/2400#discussion_r621754899
##########
File path: core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml
##########
@@ -7419,6 +7419,18 @@ from dept]]>
<![CDATA[
LogicalProject(EXPR$0=[COMPOSITE($0)])
LogicalTableScan(table=[[CATALOG, SALES, DEPT]])
+]]>
+ </Resource>
+ </TestCase>
+ <TestCase name="testFunctionExprInOver">
+ <Resource name="sql">
+ <![CDATA[select deptno, rank() over(partition by empno order by deptno) from emp]]>
+ </Resource>
Review comment:
TIPS: sql text seems not right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org