[GitHub] [ozone] xBis7 commented on a diff in pull request #4555: HDDS-8340. Recon Show the number of containers that have been DELETED in UI.

["xBis7 (via GitHub)" <gi...@apache.org>]

xBis7 commented on code in PR #4555:
URL: https://github.com/apache/ozone/pull/4555#discussion_r1170341845


##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/overview/overview.tsx:
##########
@@ -227,6 +231,9 @@ export class Overview extends React.Component<Record<string, object>, IOverviewS
           <Col xs={24} sm={18} md={12} lg={12} xl={6}>
             <OverviewCard loading={loading} title='Keys' data={keys.toString()} icon='file-text'/>
           </Col>
+          <Col xs={24} sm={18} md={12} lg={12} xl={6}>
+            <OverviewCard loading={loading} title='Deleted Containers' data={deletedContainers !== undefined && deletedContainers.toString()} icon='delete' />

Review Comment:
   This check seems redundant `deletedContainers !== undefined`, unless there is a chance that the server response won't contain it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org