You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "JosiahWI (via GitHub)" <gi...@apache.org> on 2023/06/12 11:40:12 UTC

[GitHub] [trafficserver] JosiahWI opened a new pull request, #9826: Remove TS_HAS_LIBZ

JosiahWI opened a new pull request, #9826:
URL: https://github.com/apache/trafficserver/pull/9826

   We don't use this define anywhere, and zlib is required to compile the esi plugin.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] JosiahWI commented on pull request #9826: Remove TS_HAS_LIBZ

Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #9826:
URL: https://github.com/apache/trafficserver/pull/9826#issuecomment-1589182338

   I just tried building without it, and autotools gave me an error that it could not find zlib.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] bneradt merged pull request #9826: Remove TS_HAS_LIBZ

Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt merged PR #9826:
URL: https://github.com/apache/trafficserver/pull/9826


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] cmcfarlen commented on pull request #9826: Remove TS_HAS_LIBZ

Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #9826:
URL: https://github.com/apache/trafficserver/pull/9826#issuecomment-1588186918

   are we sure this doesn't break builds without zlib that would have worked with the CPP conditionals?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] JosiahWI commented on pull request #9826: Remove TS_HAS_LIBZ

Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #9826:
URL: https://github.com/apache/trafficserver/pull/9826#issuecomment-1589447640

   [approve ci autest]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org